[#14047] - Use $ismoo instend of calling jinput
- Fixed in Code Base
- 13 Feb 2017
- Medium
- Build: staging
- # 14047
- Diff
- zero-24:zero-24-patch-3
User tests: Successful: Unsuccessful:
Pull Request for Issue #13306
Summary of Changes
- Use $ismoo instend of calling jinput
- a bit CS
Testing Instructions
- Open an administrator form that has a User form field on it (i.e. User Notes)
- Type a user name or keyword into the search box and submit
- Click one of the resulting users; the dialog is dismissed
Expected result
The user selected in the pop-up should populate the user form field.
Actual result
In 3.6.5 it is broken as the $ismoo value is missing.
In 3.7-dev it is working but don't uses the $ismoo it gets the value from the jinput object
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users |
Since you made this change, could you please this line https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_users/views/users/tmpl/modal.php#L23 to
$input = JFactory::getApplication()->input;and remove the line above https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_users/views/users/tmpl/modal.php#L22
(The $app variable is used one time only, thus it should be removed)
| Labels |
Added:
?
|
||
Done thanks @joomdonation
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14047.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14047.
| Status | Pending | ⇒ | Ready to Commit |
RTC
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-13 23:38:26 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on abccdaf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14047.