[#14043] - Lazyload the pathway
- Closed
- 19 Feb 2017
- Medium
- Build: staging
- # 14043
- Diff
- mbabker:lazyload-pathway
User tests: Successful: Unsuccessful:
Summary of Changes
The JPathwaySite constructor attempts to arbitrarily build the pathway for each instantiated object. Instead of this being a constructor behavior that happens on every load, let's make this a lazy load behavior that is only set up when the data is read.
Testing Instructions
The pathway should still be loaded correctly when it is interacted with.
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I think the error happens because recurring function call on this line https://github.com/mbabker/joomla-cms/blob/0096db6b2431ff0a38f2211269726fd01e50f8f5/libraries/cms/pathway/site.php#L83
When you first call the method, the method loadPathway is called, and the line of code above is calling again and again
We must find a way to mark loaded status of the pathway instead of relying on empty check
| Labels |
Added:
?
|
||
This isn't going to work...
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-19 15:52:17 |
| Closed_By | ⇒ | mbabker |
I have tested this item? unsuccessfully on 0096db6
Applied that patch and received the error messages below:
Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 262144 bytes) in E:\www\beta3\libraries\cms\application\cms.php on line 443
Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 262144 bytes) in Unknown on line 0
Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 262144 bytes) in Unknown on line 0
Tested by installing default sample data and click on Your Profile menu item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14043.