? ? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
12 Feb 2017

Summary of Changes

The web application routers were removed in the 4.0 branch in favor of using the Framework's Router package. 1.x of this package requires a Joomla\Controller\ControllerInterface implementation, of which it is impossible to do with existing CMS code. This PR therefore makes the "no MVC" controller base class and interface compatible with the Framework's Controller package.

Testing Instructions

Code review

Documentation Changes Required

The $app and $input properties will now be private, requiring the use of the appropriate getters to retrieve this objects in subclasses.

If merged this will be added to https://docs.joomla.org/Potential_backward_compatibility_issues_in_Joomla_4

avatar mbabker mbabker - open - 12 Feb 2017
avatar mbabker mbabker - change - 12 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2017
Category External Library Libraries
avatar mbabker mbabker - change - 12 Feb 2017
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2017
Category External Library Libraries External Library Libraries Unit Tests
avatar wilsonge
wilsonge - comment - 23 Feb 2017

We need to test com_config to merge this - and just make sure that all still works as expected as that all runs on new mvc

avatar mbabker mbabker - change - 12 Mar 2017
Labels Added: ?
avatar mbabker mbabker - change - 12 Mar 2017
The description was changed
avatar mbabker mbabker - edited - 12 Mar 2017
avatar mbabker
mbabker - comment - 12 Mar 2017

Rebased

avatar joomla-cms-bot joomla-cms-bot - change - 12 Mar 2017
Category External Library Libraries Unit Tests Administration com_config Front End External Library Libraries
avatar mbabker mbabker - change - 7 May 2017
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2017
Category External Library Libraries Administration com_config Front End Administration com_config Front End External Library Libraries Unit Tests
avatar mbabker mbabker - change - 7 May 2017
The description was changed
avatar mbabker mbabker - edited - 7 May 2017
avatar mbabker
mbabker - comment - 7 May 2017

Rebased and updated.

avatar wilsonge wilsonge - change - 8 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-08 08:43:13
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 8 May 2017
avatar wilsonge wilsonge - merge - 8 May 2017
avatar wilsonge
wilsonge - comment - 8 May 2017

Thanks!

Add a Comment

Login with GitHub to post a comment