[#14036] - Select client_id as this is required for sorting objects
- Closed
- 12 Feb 2017
- Medium
- Build: staging
- # 14036
- Diff
- roland-d:undefined-property-client-id
User tests: Successful: Unsuccessful:
Summary of Changes
In the current staging after logging in the page is full of undefined property client_id. This change fixes that by loading the client_id.
Testing Instructions
- Set error reporting to development
public $error_reporting = 'development'; - Log in to the administrator section
- You see a blue screen with notices of undefined property_client_id.
- Apply patch
- Reload page
- Log out
- Log in
- Now you are logged in and see the control panel
Expected result
To login and see the control panel
Actual result
Page is full with notices
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
@franz-wohlkoenig I see them as soon as I log in. This is using the staging branch by the way.
I get the notice because this line wants to use client_id field:
https://github.com/roland-d/joomla-cms/blob/e651965e9972d48148587b6eeb9e0833330606be/administrator/modules/mod_menu/preset/enabled.php#L165-L165
However the getMenus() the line before doesn't return that field in it's dataset. This is why the undefined property is triggered.
so i cannot test PR.
Going to close this because I found that in the installation folder the table menu_types has a client_id field. This was just not added when I fixed the database table. Adding that column fixed all the notices.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-12 13:08:40 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Added:
?
|
||
using Error-Report="Development", after login in Backend is no "blue screen with notices of undefined property_client_id".
Can you please advice where or how to see notices?