? ?

Pending

User tests: Successful: Unsuccessful:

avatar bertmert
bertmert
11 Feb 2017

Summary of Changes

  • Removed lines
<?php if ($field->name === 'contact_email_copy' && !$this->params->get('show_email_copy')) : ?>
<?php continue; ?>
<?php endif; ?>
  • Because
    • $field->name never equals 'contact_email_copy' (should be $field->fieldname instead).
    • Setting Send Copy to Submitter (show_email_copy) works correctly without these lines above.

Testing Instructions

  • Create a contact (com_contact).

  • Create a menu item (Single Contact) and apply this contact.

  • In created contact, tabulator Form: Test setting Send Copy to Submitter (Show|Hide) if field Send a copy to yourself is shown correctly or not.

  • Apply patch. Test again Send Copy to Submitter (Show|Hide) if field Send a copy to yourself is shown correctly or not.

avatar bertmert bertmert - open - 11 Feb 2017
avatar bertmert bertmert - change - 11 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2017
Category Front End com_contact
avatar bertmert bertmert - change - 11 Feb 2017
The description was changed
avatar bertmert bertmert - edited - 11 Feb 2017
avatar bertmert bertmert - change - 11 Feb 2017
The description was changed
avatar bertmert bertmert - edited - 11 Feb 2017
avatar joomdonation
joomdonation - comment - 12 Feb 2017

I have tested this item successfully on 20d703d

That block of code is not needed:

  1. $field->name is wrong, it should be $field->fieldname as @bertmert mentioned.

  2. The field is removed in model already https://github.com/joomla/joomla-cms/blob/staging/components/com_contact/models/contact.php#L100-L103 (if Send Copy to Submitter parameter set to No).


    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14029.

avatar joomdonation joomdonation - test_item - 12 Feb 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Feb 2017

I have tested this item successfully on 20d703d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14029.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 12 Feb 2017 - Tested successfully
avatar zero-24 zero-24 - change - 12 Feb 2017
Milestone Added:
Status Pending Ready to Commit
Labels Added: ? ?
avatar rdeutz rdeutz - change - 12 Feb 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-12 15:51:42
Closed_By rdeutz
Labels
avatar rdeutz rdeutz - close - 12 Feb 2017
avatar rdeutz rdeutz - merge - 12 Feb 2017

Add a Comment

Login with GitHub to post a comment