Feeling Lucky
?
?
[#14029] - com_contact, single contact. Remove useless check of contact_email_copy
- Fixed in Code Base
- 12 Feb 2017
- Medium
- Build: staging
- # 14029
- Diff
- bertmert:patch-5
User tests: Successful: Unsuccessful:
Summary of Changes
- Removed lines
<?php if ($field->name === 'contact_email_copy' && !$this->params->get('show_email_copy')) : ?>
<?php continue; ?>
<?php endif; ?>
- Because
-
$field->namenever equals'contact_email_copy'(should be$field->fieldnameinstead).
-
- Setting
Send Copy to Submitter (show_email_copy)works correctly without these lines above.
- Setting
Testing Instructions
-
Create a contact (com_contact).
-
Create a menu item (Single Contact) and apply this contact.
-
In created contact, tabulator
Form: Test settingSend Copy to Submitter(Show|Hide) if fieldSend a copy to yourselfis shown correctly or not. -
Apply patch. Test again
Send Copy to Submitter(Show|Hide) if fieldSend a copy to yourselfis shown correctly or not.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
franz-wohlkoenig
- comment
- 12 Feb 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14029.
zero-24
- | Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-12 15:51:42 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
I have tested this item✅ successfully on 20d703d
That block of code is not needed:
$field->name is wrong, it should be $field->fieldname as @bertmert mentioned.
The field is removed in model already https://github.com/joomla/joomla-cms/blob/staging/components/com_contact/models/contact.php#L100-L103 (if Send Copy to Submitter parameter set to No).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14029.