? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
11 Feb 2017

Pull Request for Issue #13263 .
there is no more need now for findInSet()

Summary of Changes

remove findInSet()

Testing Instructions

code review

avatar alikon alikon - open - 11 Feb 2017
avatar alikon alikon - change - 11 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2017
Category Libraries Postgresql MS SQL
avatar csthomas
csthomas - comment - 11 Feb 2017

I have tested this item successfully on 3f9f6e4

Code review OK.
It is not important but you may want to remove empty line which left (before removed function) in libraries/joomla/database/query/sqlsrv.php


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14020.

avatar csthomas csthomas - test_item - 11 Feb 2017 - Tested successfully
682d1d1 11 Feb 2017 avatar alikon cs
avatar alikon alikon - change - 11 Feb 2017
Labels Added: ?
avatar csthomas
csthomas - comment - 11 Feb 2017

I have tested this item successfully on 682d1d1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14020.

avatar csthomas csthomas - test_item - 11 Feb 2017 - Tested successfully
avatar wilsonge wilsonge - change - 14 Feb 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-14 13:18:46
Closed_By wilsonge
avatar wilsonge wilsonge - close - 14 Feb 2017
avatar wilsonge wilsonge - merge - 14 Feb 2017

Add a Comment

Login with GitHub to post a comment