[#14007] - Fixing ShowOn multilevel field groups issue - Issue #14002
- Fixed in Code Base
- 22 May 2017
- Medium
- Build: staging
- # 14007
- Diff
- tassosm:FixShowOnMultiLevels
User tests: Successful: Unsuccessful:
Pull Request for Issue #14002
Summary of Changes
Adds support for multi-level field groups to parseShowOnConditions() method.
Testing Instructions
Follow the description of the issue #14002 check and confirm the issue
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Permissions fixed. Why AppVeyor fails?
Is this going to be merged before 3.7 release?
Is this going to be merged before 3.7 release?
no
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14007.
I'm not talking about the tests I'm talking about the conflicts ;)
I have tested this item
It works! thank you! ;)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14007.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14007.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Pending |
| Labels | |||
Reverted back to pending as there's been functional code changes. Can we have tests again please.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14007.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14007.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14007.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-22 18:08:43 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
@laoneo looks like it got removed by https://github.com/joomla/joomla-cms/pull/16396/files#diff-35f4860b046f28ad5ca0748aae081179R452 any idea why?
Guess I missed that one or the merge from staging into 3.8 at that time had a conflict. But I didn't do it on purpose.
Is this going to be merged in 3.8 somehow or do I need to make a new PR?
Yes, please make a new pr.
I will. But in my humble view, asking for a PR for a bug that is already fixed doesn't seem right.
Please can you set the file permissions back to 644!