Feeling Lucky
?
[#13995] - Update SQL DLLs to release 4.1.6 for >php 7
- Fixed in Code Base
- 9 Feb 2017
- Medium
- Build: staging
- # 13995
- Diff
- photodude:patch-5
User tests: Successful: Unsuccessful:
Pull Request for Issue update SQL DLLs to release 4.1.6 for >php 7
Summary of Changes
- update SQL DLLs to release 4.1.6 for >php 7
- remove shallow clone, this can cause issues depending on what's excluded in the .gitignore file
- simplify getting the SQL dlls with the new PECL download location
- simplify getting the wincache dlls from PECL download locations
Testing Instructions
Merge by code review/builds pass
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
mbabker
- comment
- 9 Feb 2017
Done
photodude
- comment
- 9 Feb 2017
This PR is ready for review
wilsonge
- comment
- 9 Feb 2017
I still have no clue what's going on in this file. but tests pass. So i'll blindly trust you xD
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-09 17:59:09 |
| Closed_By | ⇒ | wilsonge |
photodude
- comment
- 9 Feb 2017
@wilsonge I'm making the changes, I work on windows and I'm still not sure I know what's going on in this file either between the yml, bat, and powershell syntaxes. It's a lot of brick smashing with my head. xD
Eventually I need to figure out the whole caching side to try and speed up the builds.
@mbabker @rdeutz @wilsonge @zero-24 can someone cancel the AppVeyor build for "wincache version is conditional" It's going to be stalled for over an hour for some reason.