Feeling Lucky
?
[#13990] - Fix Edit state permission issue in "Create Article" menu item
- Closed
- 14 May 2017
- Medium
- Build: staging
- # 13990
- Diff
- joomdonation:patch-15
User tests: Successful: Unsuccessful:
Pull Request for Issue #13654 .
Summary of Changes
This PR fixes the issues described on #13654. Further more, it makes some improvements to the code of com_content:
-
Re-use method canEditState for checking Edit State permission instead of using if ... else... block
-
Passing $record variable to parent::canEditState call at https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/models/article.php#L211 . Without the variable, there will be PHP notice
Testing Instructions
- Follow the description of the issue ##13654, check and confirm the issue
- Apply patch, check and make sure the issue is fixed
- Try to add/edit article in the backend, make sure it is working as expected
It would be great if someone can help reviewing the code changes, too.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Front End |
franz-wohlkoenig
- comment
- 22 Feb 2017
this needs a 2nd successfully Test.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-14 01:39:41 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on af94431
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13990.