? ? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
8 Feb 2017

Summary of Changes

This fixes the lft & rgt values for all our sample data. Thanks @infograf768

Testing Instructions

After the installation please clear the tables and do a complete reinstall

Expected result

Install should work and all menu entrys should work too

Actual result

After the lastest #__menu changes we had some issues with the frontend menus

Documentation Changes Required

None

Open Points

As i have no Postgress nor Mssql Envoirment this needs to be done by someone else. I'm going to open a new issue for that and link it from here.

avatar zero-24 zero-24 - open - 8 Feb 2017
avatar zero-24 zero-24 - change - 8 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2017
Category SQL Installation
avatar zero-24
zero-24 - comment - 8 Feb 2017

Issue for postgress and mssql: #13981

avatar zero-24 zero-24 - change - 9 Feb 2017
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 9 Feb 2017

I have tested this item successfully on be8f148


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13979.

avatar infograf768 infograf768 - test_item - 9 Feb 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Feb 2017

After the installation please clear the tables and do a complete reinstall

@zero-24 Clear all Tables in phpMyAdmin & reinstall of Joomla! 3.7.0-beta?

avatar zero-24
zero-24 - comment - 9 Feb 2017

@zero-24 Clear all Tables in phpMyAdmin & reinstall of Joomla! 3.7.0-beta?

Yes but the reinstall should be based on my changes so a new install with different sample data of https://github.com/zero-24/joomla-cms/archive/fix_broken_menus.zip

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Feb 2017

First install

Test on "English (GB) Sample Data"

All Front End Views

404: index.php/single-news-feed

Modules

Feed not found: index.php/feed-display

Second Install

Test on "Blog English (GB) Sample Data"
All works.

avatar infograf768
infograf768 - comment - 10 Feb 2017

@franz-wohlkoenig
Looks like your fail test is rather using sample_testing.sql and not basic sample_data.sql

We indeed have an error in sample_testing.sql in the frontendview menutype, as we have no Newsfeed with id4
(254, 'frontendviews', 'Single News Feed', 'single-news-feed', '', 'single-news-feed', 'index.php?option=com_newsfeeds&view=newsfeed&id=4', 'component', 1, 1, 1, 17, 0, '0000-00-00 00:00:00', 0, 1, '', 0, '{"show_feed_image":"","show_feed_description":"","show_item_description":"","feed_character_count":"0","menu-anchor_title":"","menu-anchor_css":"","menu_image":"","show_page_heading":0,"page_title":"","page_heading":"","pageclass_sfx":"","menu-meta_description":"","menu-meta_keywords":"","robots":"","secure":0}', 165, 166, 0, '*', 0),
see

INSERT IGNORE INTO `#__newsfeeds` (`catid`, `id`, `name`, `alias`, `link`, `published`, `numarticles`, `cache_time`, `checked_out`, `checked_out_time`, `ordering`, `rtl`, `access`, `language`, `params`, `created`, `created_by`, `created_by_alias`, `modified`, `modified_by`, `metakey`, `metadesc`, `metadata`, `xreference`, `publish_up`, `publish_down`, `description`, `version`, `hits`, `images`) VALUES
(17, 1, 'Joomla! Announcements', 'joomla-announcements', 'http://feeds.joomla.org/JoomlaAnnouncements', 1, 5, 3600, 0, '0000-00-00 00:00:00', 1, 1, 1, 'en-GB', '{"show_feed_image":"","show_feed_description":"","show_item_description":"","feed_character_count":"0","newsfeed_layout":"","feed_display_order":""}', '2011-01-01 00:00:01', 42, 'Joomla', '0000-00-00 00:00:00', 0, '', '', '{"robots":"","rights":""}', '', '0000-00-00 00:00:00', '0000-00-00 00:00:00', '', 1, 0, ''),
(17, 2, 'New Joomla! Extensions', 'new-joomla-extensions', 'http://feeds.joomla.org/JoomlaExtensions', 1, 5, 3600, 0, '0000-00-00 00:00:00', 4, 1, 1, 'en-GB', '{"show_feed_image":"","show_feed_description":"","show_item_description":"","feed_character_count":"0","newsfeed_layout":"","feed_display_order":""}', '2011-01-01 00:00:01', 42, 'Joomla', '0000-00-00 00:00:00', 0, '', '', '{"robots":"","rights":""}', '', '0000-00-00 00:00:00', '0000-00-00 00:00:00', '', 1, 0, ''),
(17, 3, 'Joomla! Security News', 'joomla-security-news', 'http://feeds.joomla.org/JoomlaSecurityNews', 1, 5, 3600, 0, '0000-00-00 00:00:00', 2, 1, 1, 'en-GB', '{"show_feed_image":"","show_feed_description":"","show_item_description":"","feed_character_count":"0","newsfeed_layout":"","feed_display_order":""}', '2011-01-01 00:00:01', 42, 'Joomla', '0000-00-00 00:00:00', 0, '', '', '{"robots":"","rights":""}', '', '0000-00-00 00:00:00', '0000-00-00 00:00:00', '', 1, 0, '');

For the module we have
`https://community.joomla.org/blogs/community.feed?type=rss as feed display.
This is not a real feed, thus the error.

@zero-24
The first error should be easy to solve by just changing the id to an existing one.
The second error: I have no idea what is the rss feed for community
We do have it here, normally
https://www.joomla.org/rss-news-feeds.html

but it just does not give a real feed.
It may be replaced by
http://feeds.joomla.org/JoomlaMagazine which does work

avatar infograf768
infograf768 - comment - 11 Feb 2017

@franz-wohlkoenig
We can do a different PR for the issues above.
If the other menu items do work for you with each sample data, then please mark this as tested OK

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Feb 2017

@infograf768 tested using "English (GB) Sample Data" – isn't this all parts of sampedata? Tested also "Blog English (GB) Sample Data" too.

avatar infograf768
infograf768 - comment - 11 Feb 2017

English (GB) Sample Data does not contain frontend views menutype. ONly English Testing sample data does

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Feb 2017

@infograf768 testing "English Testing sample" without error is enough for "successfull"?

avatar infograf768
infograf768 - comment - 11 Feb 2017

to test, you have to test each sample data proposed.
easy way is to use the same test site instance and then delete the configuration.php and reinstall with a different sample data.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Feb 2017

I have tested this item successfully on be8f148

Same 2 Failures like reported


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13979.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 11 Feb 2017 - Tested successfully
avatar infograf768 infograf768 - change - 11 Feb 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 11 Feb 2017

rtc. thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13979.

avatar rdeutz rdeutz - change - 11 Feb 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-11 18:43:41
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 11 Feb 2017
avatar rdeutz rdeutz - merge - 11 Feb 2017
avatar zero-24
zero-24 - comment - 11 Feb 2017

@franz-wohlkoenig @infograf768 see: #14032 for the newsfeeds fixes

Add a Comment

Login with GitHub to post a comment