[#13974] - Catch date format errors
- Fixed in Code Base
- 12 Feb 2017
- Medium
- Build: staging
- # 13974
- Diff
- Bakual:Catch_date_errors
User tests: Successful: Unsuccessful:
Pull Request for Issue #13962.
This is only a partial solution for the issue raised.
Summary of Changes
This PR catches the exception which may be thrown by JFactory::getDate when the value isn't a proper date. If catched, it will show a generic message "Invalid Field: Fieldname".
This is just to prevent a big error page. Ideally we would have a formfield rule which will stop the saving process and show the fautly field. This PR doesn't do that, it just makes sure the filtering doesn't generate a big errror when it fails.
Testing Instructions
Edit an article and enter into a calendar filed (eg "Created Date") a date with wrong value. Eg use "1.5.1975" which will trigger the error.
Expected result
Should show a warning that the date is wrong but keep the page functional.
Actual result
Will show a big error
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
@tuts-22 can you please mark your test at Issue Tracker?
I have tested the request for issue #13962 and it works perfectly fine!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13974.
@franz-wohlkoenig Is that fine now?..I am new to testing so sorry for the mistake!!
at issue tracker please click blue "test this" button, mark radio-button "Tested successfully" and below "submit test result".
Done sir!!! Is that fine?
On 08-Feb-2017 11:36 PM, "Franz Wohlkönig" notifications@github.com wrote:
at issue tracker please click blue "test this" button, mark radio-button
"Tested successfully" and below "submit test result".—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13974 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AU_cDcShPQNtrh3vLZzZD5rXx9KaJmTZks5ragQ6gaJpZM4L7Cyy
.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13974.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13974.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-12 15:50:23 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on fe4b654
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13974.