[#13971] - [Isis] Template menu assignment columns
- Fixed in Code Base
- 12 Feb 2017
- Medium
- Build: staging
- # 13971
- Diff
- ciar4n:template-menu-assign
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The template styles menu assignment tab uses span3 for each block. As these blocks can exceed 4 spans, this can give unpredicable results. This PR proposes using column-count instead. For the 2.5% of browsers not supporting column-count, blocks will appear in a single column.
Testing Instructions
Apply patch and navigate to the 'Menu Assignment' tab of a template style.
Before PR
After PR
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates Templates (admin) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13971.
@C-Lodder For IE8 and IE9 columns will appear in a single column which is not perfect. Currently using spans results in blocks floating to the left which means they could land anywhere considering the varied heights of each block. They will rarely appear in the correct order and will have random spacing.
I have tested the pull request for issue #13971 and it works fine!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13971.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13971.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13971.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-12 15:50:01 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
We can't use
column-countin J3 as it's needs to support IE8