? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
7 Feb 2017

Pull Request for Issue #13960

Summary of Changes

Check if a menu exists.

Testing Instructions

See #13960

After patch the PHP logs will no more display the Notice.

avatar infograf768 infograf768 - open - 7 Feb 2017
avatar infograf768 infograf768 - change - 7 Feb 2017
Status New Pending
avatar infograf768 infograf768 - edited - 7 Feb 2017
avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2017
Category Front End
avatar joomdonation
joomdonation - comment - 8 Feb 2017

I have tested this item successfully on bc05de9

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13961.

avatar joomdonation joomdonation - test_item - 8 Feb 2017 - Tested successfully
avatar csthomas
csthomas - comment - 11 Feb 2017

I have tested this item successfully on bc05de9

Real test success but it should be nicer to not use empty function as mentioned by @joomdonation.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13961.

avatar csthomas csthomas - test_item - 11 Feb 2017 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 11 Feb 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 11 Feb 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13961.

avatar jeckodevelopment jeckodevelopment - edited - 11 Feb 2017
avatar rdeutz rdeutz - change - 11 Feb 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-11 18:45:56
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 11 Feb 2017
avatar rdeutz rdeutz - merge - 11 Feb 2017
avatar joomdonation
joomdonation - comment - 12 Feb 2017

@jeckodevelopment @rdeutz It would be nice if the change suggested by me (agreed by @csthomas) implemented before this PR is set to RTC and merged.

avatar infograf768
infograf768 - comment - 12 Feb 2017

sorry folks, read this too late.
welcome to a new PR simplifying this one as proposed.

avatar joomdonation
joomdonation - comment - 12 Feb 2017

@infograf768 Could you please make a new PR for this small change?

avatar infograf768
infograf768 - comment - 12 Feb 2017

Please test #14035

Add a Comment

Login with GitHub to post a comment