Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13956] - Fix showing user fields in a contact

? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
6 Feb 2017

Currently, fields specified in a user don't show up in the contact if the user is assigned to that contact. The Fieldgroup sliders appear, but no fields within it.

Summary of Changes

This PR changes the $userData['params'] from a JSON string to the array we expect in the onContentAfterSave method.

Testing Instructions

  • Create some user fields and save some values into it.
  • Create a contact and assign the user with the save fields to it.
  • Check out the contact in frontend.

Expected result

Get the sliders for each fieldgroup filled with the saved fields.

Actual result

Only get the sliders without any fields in it.

Documentation Changes Required

None

avatar Bakual Bakual - open - 6 Feb 2017
avatar Bakual Bakual - change - 6 Feb 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2017
Category ⇒ Front End Plugins
avatar laoneo
laoneo - comment - 7 Feb 2017

The custom fields do still get saved in the user params column.

avatar Bakual
Bakual - comment - 7 Feb 2017

Yep I know. We would have to iterate over the fields and unset them from the user params. However with #13353 this will be superfluous (since fields are no longer stored in params). I just need to update it accordingly since the whole restoring of the user into the database becomes useless then.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Feb 2017

I have tested this item ✅ successfully on 2023079

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13956.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 7 Feb 2017 - Tested successfully
avatar AlexRed
AlexRed - comment - 13 Feb 2017

I have tested this item ? unsuccessfully on 2023079

fields specified in a user don't show up in the contact

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13956.

avatar AlexRed AlexRed - test_item - 13 Feb 2017 - Tested unsuccessfully
avatar Bakual
Bakual - comment - 13 Feb 2017

fields specified in a user don't show up in the users contact

@AlexRed Did you save some values for those fields in the user form? Keep in mind they only are supposed to show up when looking at the contact page in frontend. They don't show up when you edit a contact.

avatar AlexRed
AlexRed - comment - 13 Feb 2017

yes,
but appears only the "Field" title

avatar Bakual Bakual - change - 13 Feb 2017
Labels Added: ?
avatar Bakual
Bakual - comment - 13 Feb 2017

@AlexRed I rebased the whole PR on current staging so I can rule out soem conflicts. Can you try it again? It works fine for me
contact

Maybe try also to save the user again so the field values are properly saved.

avatar AlexRed
AlexRed - comment - 13 Feb 2017

I have tested this item ✅ successfully on e91ec77

Patch ok for me

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13956.

avatar AlexRed AlexRed - test_item - 13 Feb 2017 - Tested successfully
avatar joomdonation
joomdonation - comment - 15 Feb 2017

Looks good, solved the issue I reported earlier

avatar Bakual
Bakual - comment - 15 Feb 2017

@joomdonation Can you mark it as a successfull test in JIssues?

avatar alikon
alikon - comment - 16 Feb 2017

I have tested this item ✅ successfully on e91ec77

only on 3.7 current staging not on 4.0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13956.

avatar alikon alikon - test_item - 16 Feb 2017 - Tested successfully
avatar rdeutz rdeutz - change - 16 Feb 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-02-16 19:07:13
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 16 Feb 2017
avatar rdeutz rdeutz - merge - 16 Feb 2017

Add a Comment

Login with GitHub to post a comment