?
avatar infograf768
infograf768
5 Feb 2017

Steps to reproduce the issue

Create a custom field for Articles.
Edit an article and fill the value.
Make sure the Button - Fields plugin is enabled.
With the editor, use the new Button "Fields" to enter the field just created into the editor area.
It will display {field #} (where # is the id of the field) in the editor area.

If the new Content - Fields plugin is enabled, the value of the field will display in frontend.
BUT, if disabled, then this tag {field #} will display in frontend although it should not.

@laoneo @Bakual

avatar infograf768 infograf768 - open - 5 Feb 2017
avatar joomla-cms-bot joomla-cms-bot - change - 5 Feb 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 5 Feb 2017
avatar infograf768 infograf768 - edited - 5 Feb 2017
avatar Bakual
Bakual - comment - 5 Feb 2017

That is expected behavior. If the plugin responsible for a given tag isn't enabled, then no code will parse for that tag and it can't be replaced. So it will stay in the article as it is.
It's the same behavior with the "Load Module" plugin.

avatar mbabker
mbabker - comment - 5 Feb 2017

Unless someone is going to turn this into a feature request for a post processing step that ensures all placeholder/shortcode type stuff is removed then this can be closed as noted above.

avatar infograf768
infograf768 - comment - 5 Feb 2017

closing then as behaviour, in current code implementation, can't deal with it.
a suggestion though: maybe that content plugin could be enabled by default.
whatcdonyou think?

avatar infograf768 infograf768 - change - 5 Feb 2017
The description was changed
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-02-05 15:38:35
Closed_By infograf768
avatar infograf768 infograf768 - close - 5 Feb 2017
avatar Bakual
Bakual - comment - 5 Feb 2017

maybe that content plugin could be enabled by default.

It could, yes. I left it disabled because I think most sites will not need it and it has a minor performance implication since it's going to run on each article (like each content plugin). But if people think it should be enabled by default, then I'm not going to argue ?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Feb 2017

enabled by default: +1

avatar infograf768
infograf768 - comment - 5 Feb 2017

also, i think the button field should only display in editor bar if this content plugin IS enabled.

avatar Bakual
Bakual - comment - 5 Feb 2017

also, i think the button field should only display in editor bar if this content plugin IS enabled.

Just keep it consistent with the "Load Module" plugins.

avatar mbabker
mbabker - comment - 5 Feb 2017

also, i think the button field should only display in editor bar if this content plugin IS enabled.

I wouldn't. That couples the button to a specific implementation of the plugin. Nothing stops anyone from forking the core content plugins supporting those shortcode syntax things and adapting them to do something different.

avatar infograf768
infograf768 - comment - 6 Feb 2017

See #13946 (had not read @mbabker comment yet)

Nothing stops anyone from forking the core content plugins supporting those shortcode syntax things and adapting them to do something different.

In that case they should imho also fork the existing xtd-button.
Displaying the module and fields button when the only things they will show when rendered would be {whatever} is worse

Add a Comment

Login with GitHub to post a comment