[#13917] - Make JModelLegacy::cleanCache() resilient to cache errors
- Fixed in Code Base
- 8 Feb 2017
- Medium
- Build: staging
- # 13917
- Diff
- mbabker:model-cache-clean
User tests: Successful: Unsuccessful:
Partial Pull Request for Issue #13357
Summary of Changes
Similar to #13524 this tries to make the JModelLegacy class resilient to cache related issues.
-
The call to clean the cache is now wrapped in a try/catch so a cache error doesn't result in something calling that method and catching exceptions treating the operation as a failure or an unhandled exception in general.
-
A new parameter is added to the arguments array for the cache clean event dispatched after this with a boolean flag indicating the result of the clean operation.
Testing Instructions
If the cache store fails to connect or the cache configuration is bad, the exceptions thrown by the cache API should be caught and JModelLegacy::cleanCache() won't cause an uncaught exception from the cache API to bubble up the call stack. When clearing the cache fails here, the event should be dispatched with the result flag being false.
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13917.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13917.
zero-24
- | Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-08 14:07:20 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
I have tested this item✅ successfully on a5c44ef
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13917.