? Pending

User tests: Successful: Unsuccessful:

avatar uglyeoin
uglyeoin
4 Feb 2017

It seems that this makes reference to the image_fulltext_alt but the rest of the code seems to be targeting the intro text. Shoot me down if I'm wrong, I only noticed this because I was trying to merge a conflict.

I would also question (and I really don't know the pros/cons) as to whether this could use a JLayout instead. The pro in my eyes would be code maintainability and standardisation. There may be an argument against this I really am not skilled enough to know.

Pull Request for Issue # .

Summary of Changes

It referenced the intro text instead of the full text. Fill in both items differently so you can test.

Testing Instructions

Set up an article with different intro text and full text (I suggest the text "introtext" and "fulltext").

Make sure intro image is set up with an image. Make sure intro image is set to show.

Go to a tag view ensuring the article is showing. View the source of the image and ensure there is an alt text.

Expected result

  1. Alt Text Shows.
  2. Alt text matches intro image.

Actual result

article full image alt text shows

Documentation Changes Required

n/a

avatar uglyeoin uglyeoin - open - 4 Feb 2017
avatar uglyeoin uglyeoin - change - 4 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Feb 2017
Category com_tags Front End
avatar uglyeoin uglyeoin - change - 4 Feb 2017
The description was changed
avatar uglyeoin uglyeoin - edited - 4 Feb 2017
avatar uglyeoin
uglyeoin - comment - 4 Feb 2017

@wilsonge can you check that I'm not being foolish? this should be a quick change if I'm right.

avatar wilsonge
wilsonge - comment - 4 Feb 2017

Looks correct to me :)

avatar uglyeoin
uglyeoin - comment - 6 Feb 2017

@wilsonge Do you think it should use JLayout?

avatar wilsonge
wilsonge - comment - 7 Feb 2017

No. I don't think so. Tags does it's own thing because UCM

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Feb 2017

Test on Article with different intro- and fulltext and different alt-Text on Intro- and full-Article-Image.

With and -out PR correct alt-Text of intro-Image is shown.

avatar tonypartridge tonypartridge - test_item - 19 Mar 2017 - Tested successfully
avatar tonypartridge
tonypartridge - comment - 19 Mar 2017

I have tested this item successfully on 1e6b432


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13906.

avatar tonypartridge
tonypartridge - comment - 19 Mar 2017

@franz-wohlkoenig can you confirm a test on this? Make sure no information in full image is filled out. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13906.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 19 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Mar 2017

I have tested this item successfully on 1e6b432

Test on Article show no Difference, but on Tags works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13906.

avatar wilsonge wilsonge - change - 19 Mar 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-19 10:53:35
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 19 Mar 2017
avatar wilsonge wilsonge - merge - 19 Mar 2017

Add a Comment

Login with GitHub to post a comment