[#13882] - Catch SQL exception in SQL form field
- Fixed in Code Base
- 4 Feb 2017
- Medium
- Build: staging
- # 13882
- Diff
- Digital-Peak:cf/sql-error
User tests: Successful: Unsuccessful:
Pull Request for Issue #13867.
Summary of Changes
The SQL form field should handle SQL errors and not crash the page. Actually it enqueus the error message to the application, don't know if there is a better way to handle exceptions in form fields. @mbabker and @Bakual any clue?
Testing Instructions
- Create a SQL form field with an invalid query like "An invalid query".
- Adit an article.
Expected result
An error message should be shown on the top of the page.
Actual result
The site crashes.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I'd say your proposal looks perfect. Catching the exception and converting to a message is the right thing here since we don't want to throw a full error page just because a single field doesn't work.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13882.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC #jc17de
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13882.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-04 21:45:25 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
This doesnt work - currently at 3.7b3
It works just fine. It just doesn't work the way you think it should.
Im sorry - but the leaking of mysql column names to front end users is NOT acceptable to me.
Read my other rant. You're saying this PR doesn't work. I'm saying it does. It is indeed catching exceptions. But the handling of it is crap.
I have tested this item✅ successfully on 394f474
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13882.