?
avatar PhilETaylor
PhilETaylor
2 Feb 2017

Steps to reproduce the issue

install [3.7.0beta1]
Go to /administrator/index.php?option=com_tags&view=tag&layout=edit&id=2

Expected result

Nice alignment

Actual result

screen shot 2017-02-02 at 21 20 18

System information (as much as possible)

Google Chrome

avatar PhilETaylor PhilETaylor - open - 2 Feb 2017
avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 2 Feb 2017
avatar PhilETaylor
PhilETaylor - comment - 2 Feb 2017

This is happening all over the admin console - especially with "Note" field on the right

avatar Bakual
Bakual - comment - 2 Feb 2017

I think that's like this for quite some time already (before 3.3.0 for sure). I always thought it was to give more space for those fields. Solution would be to remove the span12 class from those fields in the XML.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Feb 2017

@Bakual a resizeable Textfield for Note and Version Note starting with same Length as above Fields?

avatar Bakual
Bakual - comment - 5 Feb 2017

Don't ask me. I'm not an UX guy. :)
I agree with Phil that it looks bad to have them not aligned. Maybe they are also in the wrong place.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Feb 2017

i'm asking @cpfeifer

avatar dgt41
dgt41 - comment - 5 Feb 2017

Also check: #11897

avatar cpfeifer
cpfeifer - comment - 5 Feb 2017

I really never noticed this before, thanks for pointing it out.

I took a quick look is a more inconsistency in the CSS than meets the eye. Basically, the select inputs and yes/no input have max-width:220px, the tag select input has max-width:440px which is why it hangs over the side and fills out the container, and the text inputs have no defined width.

If all the inputs have a consistent width defined, they will line up. It's not difficult to change the numbers in the CSS, but the major concern with a CSS adjustment to core fields which are being used across the entire interface is it will change everywhere. I'm guessing those specific pixels values were used for a reason, maybe not here, but probably elsewhere.

This seems like a relatively simple fix if: we can isolate the adjustment to fix the issue where it needs to be fixed and doesn't negatively impact other areas of the interface. That might a big "if" or maybe not. Adjusting the CSS to fix this issue may cause even more problems. I can give it a try and see what happens.

avatar Bakual
Bakual - comment - 5 Feb 2017

@cpfeifer Try removing this class: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/models/forms/article.xml#L23
For the version notes field that solved it for me. The tags needs some additional change I haven't figured out yet. There is some chosen stuff and inline styles happening there as well.

avatar cpfeifer
cpfeifer - comment - 5 Feb 2017

That definitely solves the text input.

The tags have a width of 440px in the CSS and I don't know why. In this context it doesn't make sense, but I'm wondering if it's like this to accommodate another area of the interface, or if it's like this because it's never been addressed previously or it's a library default. Either one is a possibility, but if it's the later, it's much easier to deal with. I'm digging through everything to find out.

avatar cpfeifer
cpfeifer - comment - 5 Feb 2017

The tag container is only used in 5 places in the backend from what I can tell. I think it's just a matter of removing or adjusting one line of CSS, and it shouldn't have any negative consequences. I'll get a PR up shortly so we can test.

avatar cpfeifer
cpfeifer - comment - 5 Feb 2017

Here's a PR, I actually found a few more issues in the process that I added in. The module manager publish/unpublish select dates were hanging out there too.

Instead of changing the grid12 across all the components, I targeted the right sidebar (aka form-vertical) and applied CSS to the inputs inside. Simple enough. Please test :)

avatar zero-24
zero-24 - comment - 5 Feb 2017

So this one can be closed @cpfeifer ?

avatar cpfeifer
cpfeifer - comment - 5 Feb 2017

PR exists, close it up.

avatar zero-24 zero-24 - change - 5 Feb 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-02-05 20:10:51
Closed_By zero-24
avatar zero-24 zero-24 - close - 5 Feb 2017

Add a Comment

Login with GitHub to post a comment