? ? Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
2 Feb 2017

Summary of Changes

Removal of the testGetFormToken test. Main reasons are:

  • we are testing here if "JUserHelper::genRandomPassword()" works, this should be tested in a test for the "JUserHelper" class and not here
  • the test is not very stable, sometimes it fails and sometime not on the same codebase.

Testing Instructions

Code Review

Expected result

Less failed tests

avatar rdeutz rdeutz - open - 2 Feb 2017
avatar rdeutz rdeutz - change - 2 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2017
Category Unit Tests
avatar mbabker
mbabker - comment - 2 Feb 2017

Dump it. It can be written better. Right now it's too dependent on static globals.

avatar zero-24 zero-24 - change - 6 Feb 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-06 08:29:09
Closed_By zero-24
Labels Added: ? ?
avatar zero-24 zero-24 - close - 6 Feb 2017
avatar zero-24 zero-24 - merge - 6 Feb 2017

Add a Comment

Login with GitHub to post a comment