Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13840] - [namespace] Namespace JFactory correctly in Admin model

? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
1 Feb 2017

Pull Request for Issue #13839.

Summary of Changes

Fixes the missing root namespace declaration for JFactory.

Testing Instructions

  • Fresh installation of the 4.0-dev branch
  • Go to create a new field
  • Attempt to save

Expected result

Field should get saved.

Actual result

Error Fatal error: Class 'Joomla\Cms\Model\JFactory' not found in \libraries\src\Cms\Model\Admin.php on line 1158 is thrown.

Documentation Changes Required

avatar laoneo laoneo - open - 1 Feb 2017
avatar laoneo laoneo - change - 1 Feb 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Feb 2017
Category ⇒ Libraries
avatar C-Lodder
C-Lodder - comment - 1 Feb 2017

I have tested this item ✅ successfully on a74f42e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13840.

avatar C-Lodder C-Lodder - test_item - 1 Feb 2017 - Tested successfully
avatar laoneo
laoneo - comment - 1 Feb 2017

Ping @wilsonge, can be merged on review. I don't do dangerous stuff in this one ?

avatar wilsonge wilsonge - change - 1 Feb 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-02-01 12:50:47
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 1 Feb 2017
avatar wilsonge wilsonge - merge - 1 Feb 2017
avatar wilsonge
wilsonge - comment - 1 Feb 2017

Merged on review

Add a Comment

Login with GitHub to post a comment