? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
31 Jan 2017

Pull Request for Issue # .

Summary of Changes

Creates a responsive tables class allowing more data to be displayed on smaller screens. Class applied to article list.

My intent here is to give an alternative table display on smaller screens where you are not limited to the amount of data that is displayed.

Testing Instructions

Navigate to Content -> Article and resize browser window.

Before patch

com-content-table1

After patch

com-content-table2

Documentation Changes Required

None

avatar ciar4n ciar4n - open - 31 Jan 2017
avatar ciar4n ciar4n - change - 31 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2017
Category Administration com_content Templates (admin)
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 Jan 2017

I have tested this item successfully on aa771fc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13835.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 31 Jan 2017 - Tested successfully
avatar Bakual
Bakual - comment - 31 Jan 2017

Associations don't have a title when shrunk. It's also missing the clickable table headers to sort the fields.

Personally, I don't like the new small view, I prefer the current phone view.

avatar ciar4n ciar4n - change - 31 Jan 2017
Labels Added: ?
avatar ciar4n ciar4n - edited - 31 Jan 2017
avatar ciar4n
ciar4n - comment - 31 Jan 2017

Really my intent here is to give an alternative table display on smaller screens where you are not limited to the amount of data that is displayed by converting the table from a column view to a row view. The current table, although it looks neater, is very limited on how much data can be displayed. Maybe com_contents is a bad example to demonstrate however the idea may be useful elsewhere.

I used a similar approach on #13769 where it was suggested that the same technique could be used on other tables.

avatar ciar4n ciar4n - edited - 31 Jan 2017
avatar Bakual
Bakual - comment - 31 Jan 2017

For the repeatable I think this makes sense, because hiding elements doesn't make sense there.

However in regular manager tables, hiding columns is perfectly fine, and those tables already are responsive. No need to fix something that isn't broken imho.

avatar laoneo
laoneo - comment - 1 Feb 2017

I really like to have the possibility to make tables correctly responsive and not just by hiding elements. Would be nice to have that possibility also on the front end for templates available as less file to include.

avatar C-Lodder
C-Lodder - comment - 1 Feb 2017

I'd suggest removing all the columns apart from the title and checkbox columns. For mobile, this would be enough

avatar tuts-22
tuts-22 - comment - 8 Feb 2017

I have tested this item successfully on e5ff521

I have tested the request and it works fine!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13835.

avatar tuts-22 tuts-22 - test_item - 8 Feb 2017 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 11 Feb 2017

@ciar4n please look at the conflicts

avatar JoshuaLewis
JoshuaLewis - comment - 11 Feb 2017

I'm not in favor of this PR due to the display feeling more cluttered. I attached a screen shot showing with the patch and the other without. Both are responsive, this patch shows more meta data per row which ends up making the article view feel not as clean. Normally I like more meta data, but in this case it doesn't seem to add much value on small display. I suppose maybe the author, but not the permission column.

screen shot 2017-02-11 at 20 29 22


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13835.

avatar ciar4n ciar4n - change - 11 Feb 2017
The description was changed
Title
[com_content] Responsive Tables
[RFC] Responsive Tables
avatar ciar4n
ciar4n - comment - 11 Feb 2017

Conflicts fixed.

I tend to agree that for the article list and for want of as simple a view as possible on mobile devices, this PR might be a little to much. The question is, is there any table view that this layout would be needed? Are we missing any important data on any of the tables on mobile devices that should be displayed?

If so then this PR allows a workable alternative. If not then there is no need for it.

avatar C-Lodder
C-Lodder - comment - 11 Feb 2017

I normally am in favour of all your PR's Ciaran, but on this one I think it over complicates the visible data

avatar ciar4n
ciar4n - comment - 12 Feb 2017

I'm gonna close this. If a need for it arises it can be re-opened.

avatar ciar4n ciar4n - change - 12 Feb 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-02-12 08:20:40
Closed_By ciar4n
avatar ciar4n ciar4n - close - 12 Feb 2017

Add a Comment

Login with GitHub to post a comment