[#1382] - Enable search filters
- Closed
- 1 Jul 2013
- Medium
- Build: master
- # 1382
- Diff
- brianteeman:patch-16
- Foreign ID 31277
- Success default The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Code quality aside, what actually changes here? The PR just shows the spacing getting pulled out and 'array' becoming 'ARRAY'.
Thats because someone edited my pr
which was changing
$areas = $app->input->get('areas');
to
$areas = $app->input->get('areas',null,'ARRAY');
In the current master, it's already just as your patch suggests to change - https://github.com/joomla/joomla-cms/blob/master/components/com_search/models/search.php#L73
It looks like it was changed here - 8e6d064 - Tracker item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30125
Wow thats weird - i must have been looking at an old master ?
Guess this and the issue can be closed then
Code quality: space needed between , and null