Pull Request for Issue #13804 .
Adds WinCache to AppVeyor build
code review - notice there are now only 151 skipped tests where before there was 159
none
I totally overlooked that.
With the correction implemented, we now have a bunch of failures. Not sure if that is Environment setup, or Wincache issues.
Labels |
Added:
?
|
Looking through the errors it seems one of the issues stems from the call to the clean method
https://github.com/joomla/joomla-cms/blob/staging/tests/unit/core/case/cache.php#L66
might be an environment configuration issue still
So wincache is installed and loaded, but I still get the error ini_set(): Cannot find save handler 'wincache'
Not sure what's wrong in the configuration.
I think I have the right php.ini items and in the right order to get wincache working now.
looks good
Status | New | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-09 09:58:27 |
Closed_By | ⇒ | wilsonge |
I don't know well enough yet. So I trust your judgement :)
Actually, it doesn't look like it's enabling on any of the builds, just doing the download (seems the echo statements don't work right in the
ps
lines. I checked an earlier build and don't see the skipped test count going down.You should be able to do the
echo extension=php_wincache.dll >> php.ini
like we do the other extension files after the download I'd imagine.