?
avatar photodude
photodude
30 Jan 2017

Pull Request for Issue #13804 .

Summary of Changes

Adds WinCache to AppVeyor build

Testing Instructions

code review - notice there are now only 151 skipped tests where before there was 159

Documentation Changes Required

none

avatar photodude photodude - open - 30 Jan 2017
avatar mbabker
mbabker - comment - 30 Jan 2017

Actually, it doesn't look like it's enabling on any of the builds, just doing the download (seems the echo statements don't work right in the ps lines. I checked an earlier build and don't see the skipped test count going down.

You should be able to do the echo extension=php_wincache.dll >> php.ini like we do the other extension files after the download I'd imagine.

avatar photodude
photodude - comment - 30 Jan 2017

I totally overlooked that.

With the correction implemented, we now have a bunch of failures. Not sure if that is Environment setup, or Wincache issues.

avatar photodude photodude - change - 30 Jan 2017
Labels Added: ?
avatar photodude
photodude - comment - 30 Jan 2017

Looking through the errors it seems one of the issues stems from the call to the clean method
https://github.com/joomla/joomla-cms/blob/staging/tests/unit/core/case/cache.php#L66

might be an environment configuration issue still

avatar photodude
photodude - comment - 30 Jan 2017

So wincache is installed and loaded, but I still get the error ini_set(): Cannot find save handler 'wincache'
Not sure what's wrong in the configuration.

avatar photodude
photodude - comment - 31 Jan 2017

I think I have the right php.ini items and in the right order to get wincache working now.

avatar photodude
photodude - comment - 31 Jan 2017

@mbabker This should be ready to go now. With wincache correctly running we get Skipped: 137 rather than 150 something

avatar photodude
photodude - comment - 9 Feb 2017

/Ping for review @rdeutz @wilsonge @mbabker

avatar rdeutz
rdeutz - comment - 9 Feb 2017

looks good

avatar wilsonge wilsonge - change - 9 Feb 2017
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-09 09:58:27
Closed_By wilsonge
avatar wilsonge wilsonge - close - 9 Feb 2017
avatar wilsonge wilsonge - merge - 9 Feb 2017
avatar wilsonge
wilsonge - comment - 9 Feb 2017

I don't know well enough yet. So I trust your judgement :)

Add a Comment

Login with GitHub to post a comment