? ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
30 Jan 2017

Pull Request for Issue #13793

Summary of Changes

Creates a new field type to display only components which have categories created.

Testing Instructions

Create a new admin menu of type List All Categories
Before patch, we get

screen shot 2017-01-29 at 09 29 18

After patch:

screen shot 2017-01-30 at 11 47 39

Documentation Changes Required

None

@Bakual @mbabker @izharaazmi @franz-wohlkoenig

avatar infograf768 infograf768 - open - 30 Jan 2017
avatar infograf768 infograf768 - change - 30 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2017
Category Administration com_categories com_menus Language & Strings
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Jan 2017

I have tested this item successfully on bd3d98c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13808.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 30 Jan 2017 - Tested successfully
avatar izharaazmi
izharaazmi - comment - 30 Jan 2017

@infograf768 I remember few of my extensions that uses categories but
doesn't ship with a default category.

For this patch I'd rather group the list in two parts – one those you are
showing and another those you are hiding. See if you think it fit.

avatar Bakual
Bakual - comment - 30 Jan 2017

It's for sure the simplest approach allthough it will fail if there are no categories yet created.
However that is an easy fix for the user. He just needs to create a category first using the regular menu before he can create a custom category manager menuitem for that extension.

avatar infograf768 infograf768 - change - 30 Jan 2017
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 31 Jan 2017

I have simplified the new field type code.
Added the same field type when using the admin menu item "Create a category"
Modified the tip for the field to explain the user that it is necessary to create at least one category for any component in order for it to be listed.

screen shot 2017-01-31 at 07 04 10

@izharaazmi
I think this should be enough and can go in.

Folks, please test again.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 Jan 2017

I have tested this item successfully on 9c0e902


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13808.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 31 Jan 2017 - Tested successfully
avatar izharaazmi
izharaazmi - comment - 31 Jan 2017

@infograf768

that it is necessary to create at least one category for any component in order for it to be listed.

If we are okay with this, then this is good to go.

avatar infograf768 infograf768 - change - 31 Jan 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 31 Jan 2017

RTC.

If someone uses multiple categories sections, we can modify to fit.

@rdeutz

Can be merged


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13808.

avatar rdeutz rdeutz - change - 31 Jan 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-31 09:21:58
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 31 Jan 2017
avatar rdeutz rdeutz - merge - 31 Jan 2017
avatar izharaazmi
izharaazmi - comment - 31 Jan 2017

@infograf768 Can you please list the core components that are horizontal in nature and their respective url format. I need to make ensure one of my coming proposal works.

What I can see so far:

com_categories  => option=com_categories&extension=com_foo.bar, 
com_fields      => option=com_fields&extension=com_foo.bar

Are there more?

avatar Bakual
Bakual - comment - 31 Jan 2017

com_fields uses &context=com_foo.bar, not &extension=com_foo.bar.

avatar izharaazmi
izharaazmi - comment - 31 Jan 2017

Oh well. Thanks. Are there more such features apart from categories and
fields?

avatar Bakual
Bakual - comment - 31 Jan 2017

I'm not aware of it.

Add a Comment

Login with GitHub to post a comment