[#13780] - Adds inline style to hide label
- Closed
- 27 Jan 2017
- Medium
- Build: staging
- # 13780
- Diff
- tonypartridge:patch-3
User tests: Successful: Unsuccessful:
As per Georges comment we always need to render the label for Accessibility reasons regardless of the show/hide setting. This pull just adds some inline CSS to hide the label and respect the config option within the module.
Leaving behind the original classing incase it is being used already in the users template.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
Hi @mbabker
The problem with that is you need to write some css into your template or you have to load the core bootstrap. Therefore meaning this config option doesn't work.
Since it doesn't work on 90% of templates (my own guess). It's a a big fail of an option and should just be removed if we are not wanting to allow a way for it to work at most times.
Well then by that argument Joomla should just not use CSS and inline style everything.
As commented on your other item, there is an expectation that templates should be implementing the base core CSS selectors and templates that aren't doing that really should fix their errors or deal with needing to make overrides to work with their implementations.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-27 17:30:11 |
| Closed_By | ⇒ | tonypartridge | |
| Labels |
Added:
?
|
||
Well then by that argument Joomla should just not use CSS and inline style everything.
Another good point for Custom elements then
I've already closed this and won't be opening anymore soon don't worry.
There's a class already in the core CSS for this. Please use that instead of inlining some CSS (IIRC it's the
element-invisibleclass that's the preferred one).