? Pending

User tests: Successful: Unsuccessful:

avatar tonypartridge
tonypartridge
27 Jan 2017

Steps to reproduce the issue

Set description on article or anything other item to nothing. In my scenario it was using Docman where they are just documents with no content.

Expected result

html not to be rendered if there isn't a description to render

Actual result

Renders a < p > html tag with no content, causes excess padding and just a mess on most sites.

System information (as much as possible)

J3.6.5 / J3.7.0Alpha2.

Additional comments

this is just a simple change to make the output of search results which have no description inside them to not render excess html.

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Documentation Changes Required

avatar tonypartridge tonypartridge - open - 27 Jan 2017
avatar tonypartridge tonypartridge - change - 27 Jan 2017
Status New Pending
avatar tonypartridge tonypartridge - change - 27 Jan 2017
The description was changed
avatar tonypartridge tonypartridge - edited - 27 Jan 2017
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2017
Category Front End com_finder
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Jan 2017

@tonypartridge tested a Menu (link index.php?option=com_finder&view=search) and Tab Options > Result Description: Hide. In Source Code is no <p>-tag for hidden description.

avatar tonypartridge
tonypartridge - comment - 28 Jan 2017

Hello,

That's not my question. I'm not saying you want to hide descriptions. This is when this is no description to render on the item. If there is no description no tag should render.

To replicate, create an article without text just title and search it with descriptions showing a P tag is rendered.

Many thanks
Tony

avatar cpfeifer
cpfeifer - comment - 28 Jan 2017

I have tested this item successfully on 818bd8a

Works for me. Good catch :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13778.

avatar cpfeifer cpfeifer - test_item - 28 Jan 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Jan 2017

I have tested this item successfully on 818bd8a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13778.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 28 Jan 2017 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 28 Jan 2017
Milestone Added:
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 28 Jan 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13778.

avatar rdeutz rdeutz - change - 28 Jan 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-28 22:15:05
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 28 Jan 2017
avatar rdeutz rdeutz - merge - 28 Jan 2017

Add a Comment

Login with GitHub to post a comment