? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
26 Jan 2017

Pull Request for Issue # .

Summary of Changes

This PR makes subform tables responsive, switching from column to row views on smaller screens. This form is used in com_fields however applies to all subform tables

Testing Instructions

Navigate to Content -> Fields -> New. Set 'Type' to 'Checkbox', add a number of values and resize the browser window.

@laoneo This resolves the issue we discussed at the sprint regarding using subform.repeatable-table and smaller screens.

Before Patch

subform1

After Patch

subform2

Documentation Changes Required

None

avatar ciar4n ciar4n - open - 26 Jan 2017
avatar ciar4n ciar4n - change - 26 Jan 2017
Status New Pending
avatar ciar4n ciar4n - change - 26 Jan 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2017
Category Administration Templates (admin) Layout
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Jan 2017

I have tested this item successfully on 6527898


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13769.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 26 Jan 2017 - Tested successfully
avatar laoneo
laoneo - comment - 27 Jan 2017

I have tested this item successfully on 6527898

Tested it also with some bigger subform fields and it works superb. Thanks Ciaran!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13769.

avatar laoneo laoneo - test_item - 27 Jan 2017 - Tested successfully
avatar laoneo
laoneo - comment - 27 Jan 2017

I think it would be a new PR, but can this being applied for all tables to make them responsive?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13769.

avatar jeckodevelopment jeckodevelopment - change - 27 Jan 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 27 Jan 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13769.

avatar rdeutz rdeutz - change - 27 Jan 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-27 18:29:39
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 27 Jan 2017
avatar rdeutz rdeutz - merge - 27 Jan 2017
avatar ciar4n
ciar4n - comment - 27 Jan 2017

Yes.. there would be no real problem there. All that is required is that the title is added to a data attribute for each td (layouts/joomla/form/field/subform/repeatable-table/section.php).

For some tables there may be to much data to display every column in the row view. Would need to decide what rows to show and what rows to leave out for each table.

Add a Comment

Login with GitHub to post a comment