? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
26 Jan 2017

Fix for previous PR #13626

Summary of Changes

Remove semicolons lying before UNION ALL.

Testing Instructions

Code review.
Or try to install latest joomla staging

  • before patch it fails
  • after patch it works

Documentation Changes Required

No

avatar csthomas csthomas - open - 26 Jan 2017
avatar csthomas csthomas - change - 26 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2017
Category MS SQL SQL Administration com_admin Installation
avatar alikon
alikon - comment - 26 Jan 2017

ops
thanks @csthomas

avatar alikon
alikon - comment - 26 Jan 2017

I have tested this item successfully on e90bb76


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13767.

avatar alikon alikon - test_item - 26 Jan 2017 - Tested successfully
avatar waader
waader - comment - 27 Jan 2017

I have tested this item successfully on e90bb76


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13767.

avatar waader
waader - comment - 27 Jan 2017

I have tested this item successfully on e90bb76


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13767.

avatar waader waader - test_item - 27 Jan 2017 - Tested successfully
avatar laoneo
laoneo - comment - 27 Jan 2017

Ready fro RTC then. Thanks guys!! Makes me happy to see that we have a MSSQL team in place ?

avatar csthomas
csthomas - comment - 27 Jan 2017

If we want to have MSSQL version working (I talk about whole joomla) then it need more changes:

  • sql type datetime to datetime2 - missing
  • unicode chars support and escape fix - ready and waiting for tests #13585
  • GROUP BY workarounds - #13262 unfinished, need redesign a little
avatar dgt41 dgt41 - change - 27 Jan 2017
Status Pending Ready to Commit
avatar dgt41
dgt41 - comment - 27 Jan 2017

RTC

avatar rdeutz rdeutz - change - 27 Jan 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-27 18:28:49
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 27 Jan 2017
avatar rdeutz rdeutz - merge - 27 Jan 2017

Add a Comment

Login with GitHub to post a comment