? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
26 Jan 2017

Moving JTable* to namespace.

More detailed explanation can be found in #13683.

avatar laoneo laoneo - open - 26 Jan 2017
avatar laoneo laoneo - change - 26 Jan 2017
Status New Pending
avatar laoneo laoneo - edited - 26 Jan 2017
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2017
Category Libraries
avatar laoneo laoneo - change - 26 Jan 2017
Title
Move the table folder to a namespace
[namespace] Move the table folder to a namespace
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2017
Category Libraries Libraries Unit Tests
avatar laoneo laoneo - change - 26 Jan 2017
Labels Added: ?
avatar laoneo
laoneo - comment - 26 Jan 2017

Ping @wilsonge and @mbabker for a review.

avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2017
Category Libraries Unit Tests Repository Libraries External Library Unit Tests
avatar laoneo laoneo - change - 26 Jan 2017
Labels Added: ?
avatar laoneo laoneo - edited - 26 Jan 2017
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2017
Category Libraries Unit Tests Repository External Library Repository Libraries Unit Tests
avatar mbabker
mbabker - comment - 26 Jan 2017

I don't think they need a Type subnamespace. Joomla\Cms\Table\Asset is more than adequate.

avatar laoneo
laoneo - comment - 26 Jan 2017

Honestly they don't even belong there, they should be put into their components. That's why I want to separate them.

avatar mbabker
mbabker - comment - 26 Jan 2017

Except not all of the tables actually belong to a component. There's no assets component, and I'd call the update and user tables system tables versus extension tables (com_installer or com_users in this case), just using what's in the libraries/joomla/table directory.

avatar mbabker
mbabker - comment - 26 Jan 2017

So thinking out loud here, it looks like JTableContent might be the only candidate to move to an extension.

Categories and menus have library classes (JCategories and JMenu), moving the table classes couples the library and component and we should try to not do that.

Extension tables (JTableExtension and JTableModule) are also system and have management UIs exposed through a few components. So I think those are good to stay too.

As I said before, user and ACL related tables are definitely system tables. Honestly JUser and JTableUser are pretty well independent of com_users and aside from whatever internal couplings exist to the component you could presumably run a site without that component at all.

And that leaves the UCM and history tables. History I guess could be argued either way (that one is kinda bound to the component but at the same time IIRC uses UCM style data structure). UCM as I've hinted at earlier I'd love to have revisited to figure out how it ties into Joomla's future.

avatar laoneo laoneo - change - 27 Jan 2017
Title
[namespace] Move the table folder to a namespace
[namespace] Move JTable* to namespaces
Labels Removed: ?
avatar laoneo
laoneo - comment - 27 Jan 2017

Ok, moved the rest of tables as well.

avatar laoneo laoneo - change - 27 Jan 2017
The description was changed
avatar laoneo laoneo - edited - 27 Jan 2017
avatar mbabker mbabker - change - 28 Jan 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-28 15:43:28
Closed_By mbabker
avatar mbabker mbabker - close - 28 Jan 2017
avatar mbabker mbabker - merge - 28 Jan 2017
avatar wilsonge
wilsonge - comment - 28 Jan 2017

?

Add a Comment

Login with GitHub to post a comment