Feeling Lucky
?
[#13761] - [com_fields] Default the gallery directory when empty
- Fixed in Code Base
- 26 Jan 2017
- Medium
- Build: staging
- # 13761
- Diff
- Digital-Peak:gallery-empty-path
User tests: Successful: Unsuccessful:
Pull Request for Issue #13744.
Summary of Changes
On a fresh installation, when the plugin params didn't get saved, the default directory is empty. This PR handles this situation.
Testing Instructions
- Fresh installation of Joomla staging.
- Gallery plugin doesn't have to be saved.
- Create a gallery field for articles and don't put a value in the directory parameter.
- Edit an article.
Expected result
Only the subfolders of /images should be shown.
Actual result
The whole directory of the Joomla installation is shown.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
marrouchi
- comment
- 26 Jan 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13761.
marrouchi
- comment
- 26 Jan 2017
I would suggest making rather a change in /plugins/fields/gallery/params/gallery.xml (adding default & required attribs):
<field
name="directory"
type="text"
default="images"
required="true"
label="PLG_FIELDS_GALLERY_PARAMS_DIRECTORY_LABEL"
description="PLG_FIELDS_GALLERY_PARAMS_DIRECTORY_DESC"
/>
laoneo
- comment
- 26 Jan 2017
If the value in the field params arenemoty thennit should inherit from the plugin. That's why this shouldn't being defaulted.
laoneo
- comment
- 26 Jan 2017
Please set to RTC.
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-26 12:24:45 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on 93d41cb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13761.