[#13755] - duplicated code
- Closed
- 25 Jan 2017
- Medium
- Build: staging
- # 13755
- Diff
- uglyeoin:patch-5
User tests: Successful: Unsuccessful:
private static $fieldsCache = null; was written twice, surely there is no need?
Pull Request for Issue # .
Summary of Changes
Removed a duplicated line.
Testing Instructions
It is to do with field cache. I'm not enough of a coder to know exactly what this does so someone else would be better off writing this description.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
Also note that if this section of code had proper Unit testing your change would have failed the CI tests on submission
they are not the same variable $fieldsCache is different from $fieldCache
Oh yes, there's an additional S. I knew there had to be a reason for this, I'll shut this down if I can find out how
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-25 18:27:26 |
| Closed_By | ⇒ | uglyeoin | |
| Labels |
Added:
?
|
||
The use of the word "cache" is misleading. I would suggest renaming to "$fieldModel" and "$fieldsModel".
The one is $fieldsCache the other is
$fieldCacheNote that the one you deleted is singular and the other is plural they are both needed.What is needed here is a member var comment
See the coding standards on Class Property DocBlocks http://joomla.github.io/coding-standards/?coding-standards/chapters/docblocks.md