? ? ? Pending

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
25 Jan 2017

Summary of Changes

Admin menu manager currently uses heading menu type flag to set components menu items container. Now we will have another menu type under "System Links" by name "Components Menu Container"

Testing Instructions

Create a new custom admin menu.
Create a menu item of type System Links > Components Menu Container
Make sure the components container menu item shows all published menu items of type "Main (Protected)"

Documentation Changes Required

Not sure.

avatar izharaazmi izharaazmi - open - 25 Jan 2017
avatar izharaazmi izharaazmi - change - 25 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jan 2017
Category Administration com_menus Language & Strings Modules
avatar izharaazmi izharaazmi - change - 25 Jan 2017
Labels Added: ? ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Jan 2017

I have tested this item successfully on a0595ab

"Components Menu Container" show im Menu all Menues of default "Components".

But got Warning: The active administrator menu does not contain links to Module Manager and Menu Manager. Click to turn on the menu recovery mode.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13749.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 25 Jan 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 25 Jan 2017

@izharaazmi
The new menu item should only display when adding to a custom admin menu.
That's why I added to my fast patch
if ($this->get('State')->get('client_id') == 1) in menutypes.view.html.php

avatar izharaazmi
izharaazmi - comment - 26 Jan 2017

@infograf768 I'm sorry that I missed it. PR updated.

avatar infograf768
infograf768 - comment - 26 Jan 2017

I have tested this item successfully on a8bc547


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13749.

avatar infograf768 infograf768 - test_item - 26 Jan 2017 - Tested successfully
avatar infograf768 infograf768 - alter_testresult - 26 Jan 2017 - franz-wohlkoenig: Tested successfully
avatar infograf768 infograf768 - change - 26 Jan 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 26 Jan 2017

As the correction was simple. RTC.

@rdeutz Can be merged


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13749.

avatar rdeutz rdeutz - change - 26 Jan 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-26 07:58:38
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 26 Jan 2017
avatar rdeutz rdeutz - merge - 26 Jan 2017

Add a Comment

Login with GitHub to post a comment