[#13747] - Fix various router issues related to com_content
- Closed
- 29 Jan 2017
- Medium
- Build: staging
- # 13747
- Diff
- wilsonge:router-single-route
User tests: Successful: Unsuccessful:
Summary of Changes
Fixes a variety of bugs in the new 3.7 router (I was specifically testing com_content but this is also more general - as I've also made the same patches to contact and newsfeeds)
Thanks to @mbabker for the help debugging some of these issues on Sunday!!
Testing Instructions
Install staging (or latest version of Joomla 3.7.0 - currently alpha 2) with no sample data.
In the article manager create 3 articles
- Article 1 should be featured and uncategorised
- Article 2 should not be featured and also uncategorised
- Article 3 should be in a secondary category
- Create a child menu item of the featured home page for article 1
- Create a category list menu item for the secondary category as a top level menu item
Ensure that articles 1-3 all have links to each other. Note importantly here article 2 has no menu item and it's category has no menu item. This is running through lots of fallback behaviour and where bugs start to creep in.
Ensure you've turned on modern URL routing and Remove ID's for com_content
Firstly go to your single item menu item for article
- Try navigating to article 2
- Note that the article cannot be accessed.
- Apply patch.
- You can now access the article.
- Revert Patch
- Go to the category list view you create and go into article 3
- Go to article 2
- Note you go back to to the category 2 view and not article 2.
- Apply patch
- You go correctly to article 2
I think this also should help with the video described in This might help with issue #13747 (but I only did limited testing as I wasn't deliberately trying to fix that bug)
Please test the router just generally in as many configurations as possible and check for any breaks in behaviour this patch may introduce. It's not 'trivial' bug fixes - it's possible there could be unintended side-effects. Please don't report any pre-existing bugs that exist before and after this patch - but open a new issue instead :)
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content Libraries |
| Labels |
Added:
?
?
|
||
| Category | Front End com_content Libraries | ⇒ | Front End com_content Libraries Unit Tests |
There's no beta 1 but yeah I'll take 3.7 alpha 2 or staging branch
Go to the category list view you create and go into article 3
Go to article 2
Cant get navigation show to got from article 3 to article 2.
| Labels |
Added:
?
|
||
| Category | Front End com_content Libraries Unit Tests | ⇒ | Front End com_contact com_content com_newsfeeds Libraries Unit Tests |
@franz-wohlkoenig can you give it another go please. Looks like there was a bug with no id's enabled i had missed
Article 1 name: feat-uncat-01
Article 2 name: not-feat-uncat-02
Article 3 name: not-feat-uncat-2ndcat-03
- Open "feat-uncat-01" in single item menu item: Works
- Try navigating to article "not-feat-uncat-02" by click on Navigation-Button "Next":
404 Article not found. Request-Url:/index.php/home/feat-uncat-01/article/not-feat-uncat-02
ok, patch work, now I can open the Article 2.
But the link URL to Article 2 in the homepage link inside the Article 1 is not SEO: "/?view=article&id=2"
also the link URL to Article 2 in the "Latest Articles" module is not SEO.
The link URL to Article 2 inside the Article 3 is ok, also inside the Article 1 (directly, not from the homepage) is ok.
The 404 error also do not work: #2822
and also "List All Categories" menu item type do not work: #13101
@franz-wohlkoenig I can't replicate that on my setup a url http://localhost/~george/joomla-cms/index.php/home/test01-menu/article/2-test02 correctly parses for me
I'm on chrome on sierra and have tested in chrome + safari + firefox with successful results :) Can I see a screenshot of your article and menu manager please? I'm sure we must be doing something different somewhere - just can't work out what :)
Not shown 2nd Article:
Menu-Manager:
Thanks for addressing these issues, I was about to add this in then I found this PR :)
I'm having the same issue with Article 2, everything else is good.
I navigate to my article 1 menu sub-item article with links to articles 2 & 3. When I navigate to Article 2 without the patch, it reloads the Article 1 page - similar to the Article 3 cat list scenario. With the patch applied I get a 404 error.
Everything else works as expected for me.
I still can't replicate the issues you guys have. Here is my setup. Going between any combination of articles 1, 2 and 3 things 'work' there are definitely some URLs that don't work use their proper SEF link yet. But they all go to the right place for me. What have you guys set up differently?
Category's
Articles
Menus
I don't see any differences in my setup, other than I already had sample data in my install and I built this in rather than re-installing. Maybe can you see something I'm missing.
Screenshots of Menu and Articles
I'm using the Sample Data Category for Article 3 and the other two are Uncategorized.
When I go to the featured-test / Single Article and click on the link to article 2 (inserted through the editor article link button), it gives me a 404 with this URL:
featured-test/single-article-test/article/article-url-testing-2
Maybe that helps? It seems like this should work even if there is a variance in the testing method. Or maybe I'm missing something, it wouldn't be the first time that happened :)
It looks ok :/ Can i get access to one of you two over skype or something so I can try and debug on your setups?
Give me 10 minutes and I'll ping you
It's fine. Having discussed this with Cliff I've figured out that on my small setup of 3 articles and 2 categories this worked. But this is no good for real life sites. There's several fundamental issues.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-29 13:14:21 |
| Closed_By | ⇒ | wilsonge |
3.7.0-beta1?