[#13745] - [com_fields] Load language files from components
- Fixed in Code Base
- 26 Jan 2017
- Medium
- Build: staging
- # 13745
- Diff
- Bakual:LoadLanguageFilesFromComponents
User tests: Successful: Unsuccessful:
Currently, in the com_fields views the language files for the components are only loaded from the global language folder. However the components may also have them in their own language folder.
Summary of Changes
Adjusts the loading of language files to also have a look in the components language folder.
Testing Instructions
- Install an extension which supports fields already. You may use my SermonSpeaker component (GitHub branch with fields support is https://github.com/Bakual/SermonSpeaker/tree/SermonSpeaker5.6. Just zip the "com_sermonspeaker" folder and install it)
- Go to the field and field group manager and the respective edit forms in SermonSpeaker and watch the header of the page. You'll see an untranslated string there. After applying the PR the strings will be translated.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
Would not it be important to add null, false, true ?
Those are the default values of the method anyway (https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/language/language.php#L707), so they can be omitted. It just doesn't matter.
public function load($extension = 'joomla', $basePath = JPATH_BASE, $lang = null, $reload = false, $default = true)
But the JPath::clean() could be added indeed. I can do that later.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13745.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13745.
| Labels |
Added:
?
|
||
Added JPath::clean() to be consistent with other places. It shouldn't change anything.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13745.
| Status | Pending | ⇒ | Ready to Commit |
RTC as Cleaning the path has no impact on former tests.
@rdeutz can be merged
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13745.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-26 12:30:09 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Elsewhere in core we have:
Would not it be important to add
null, false, true?