? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
23 Jan 2017

Pull Request for Issue #13719

Summary of Changes

Code Style for the silently merged new admin template

Testing Instructions

@wilsonge

Documentation Changes Required

avatar zero-24 zero-24 - open - 23 Jan 2017
avatar zero-24 zero-24 - change - 23 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jan 2017
Category Administration com_banners com_categories com_contact com_content com_menus com_newsfeeds com_users Modules Templates (admin) Libraries
avatar zero-24 zero-24 - change - 23 Jan 2017
Title
codestyle fist part ..
[4.0] Codestyle fist part ..
avatar zero-24 zero-24 - edited - 23 Jan 2017
avatar wilsonge wilsonge - change - 23 Jan 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-23 20:19:57
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 23 Jan 2017
avatar wilsonge wilsonge - merge - 23 Jan 2017
avatar wilsonge
wilsonge - comment - 23 Jan 2017

Thanking you muchly. Time to fix CS and unit tests is required before it is publically announced :)

avatar zero-24
zero-24 - comment - 23 Jan 2017

Time to fix CS and unit tests is required before it is publically announced :)

Before it is committed. That is the reason every pull request include unit and cs checks..

avatar mbabker
mbabker - comment - 23 Jan 2017

You do realize that we don't have Travis-CI on private repositories because we aren't paying for that, right? Meaning there were none of these checks happening before the work was transferred here. And if the work would've been submitted as a PR it would've taken 6 months to get merged because everyone would've found time to get a design degree to make comments about the design.

Add a Comment

Login with GitHub to post a comment