?
avatar mbabker
mbabker
23 Jan 2017

Not urgent, but the now namespaced MVC classes shouldn't use the aliases otherwise when we run the job to build https://api.joomla.org it'll make some of the navigation not work right (i.e. it won't link to the class it extends if it's using an alias without creating a stub class when running the job). So at some point this should use the "correct" class names.

Also, the file doc blocks don't need the package/subpackage tags in namespaced classes. Those are really only there to be able to group stuff for the API documentation output (which has been semi-broken in phpDocumentor for a while anyway unfortunately). See https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Cms/Session/Storage/JoomlaStorage.php for an example of a file doc block being used on the namespaced code in the 4.0 branch (I think we had to make a change to the PHPCS ruleset to make it work right there, check that directory and backport the change if necessary).

avatar mbabker mbabker - open - 23 Jan 2017
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jan 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 23 Jan 2017
avatar laoneo
laoneo - comment - 24 Jan 2017

It should be changed as with the merge of Views and Models. Can you have a lok please, I guess it is solved.

avatar mbabker
mbabker - comment - 24 Jan 2017

The class extensions are fine, just needs the file doc block updates now.

avatar laoneo
laoneo - comment - 26 Jan 2017

I'v adapted them to the doc block in the 4 branch directly in this PR #13765 with commit 2aba65c

avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Mar 2017
Category Code style
avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Apr 2017
Status New Needs Review
avatar mbabker mbabker - change - 27 Apr 2017
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2017-04-27 01:20:45
Closed_By mbabker
avatar mbabker mbabker - close - 27 Apr 2017

Add a Comment

Login with GitHub to post a comment