tests need to be re-written to cater for BS4

tests need to be re-written to cater for BS4

? Should have been done before we merge it into the core?

First Part: #13723

Seccond part: #13724

@wilsonge please review and merge so we can be sure we are ok.

@C-Lodder What in the Code standards need to be rewritten?

I'm not seeing anything other than files that are no longer excluded that have code style issues. (some of these can be fixed with the auto fixers in the PHPCS 2 version of the coding standards See joomla/coding-standards#143 for items relating to the upcoming Alpha release)

@photodude - Code Standards for Bootstrap?

Were there any for BS2? If so, could I have a link please to get a better idea

@C-Lodder our current (needing revision) code standards for JS are here in the manual (until the gh-pages find a new home) http://joomla.github.io/coding-standards/?coding-standards/chapters/javascript.md

but JS files and mixed php/html files are not CI checked for code standards. We currently only check pure PHP files (and not all of them).

Ah didn't know the CS page had requirements for CSS. I'll make the necessary updates for the SCSS tomorrow.

Yep we have CS items for
PHP Code
XML
and the Clientside Syntaxs
HTML
CSS
JavaScript

@photodude : joomla/coding-standards#146