? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
23 Jan 2017

Pull Request for Issue #13705.

Testing instructions

  • Create some custom fields for articles
  • Edit an article
  • Create a news flash module
  • Make an override
  • Check if the articles do have a $item->fields property available
avatar laoneo laoneo - open - 23 Jan 2017
avatar laoneo laoneo - change - 23 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jan 2017
Category Modules Front End
avatar laoneo laoneo - change - 23 Jan 2017
Labels Added: ?
avatar zero-24
zero-24 - comment - 23 Jan 2017

Can you please add a quick test example?

avatar Bakual
Bakual - comment - 23 Jan 2017

Just a stupid question, do we still need the $item->introtext = JHtml::_('content.prepare', $item->introtext, '', 'mod_articles_news.content'); then? Because that one afaik triggers the same event but only with the introtext instead of the full item.

avatar laoneo
laoneo - comment - 24 Jan 2017

Guess not.

avatar coolcat-creations
coolcat-creations - comment - 24 Jan 2017

tested with and without$item->introtext = JHtml::_('content.prepare', $item->introtext, '', 'mod_articles_news.content'); and it works.

avatar Bakual
Bakual - comment - 24 Jan 2017

You would have to test if content plugins tags within that introtext are still correctly replaced. That's what the content.prepare event usually does take care of.

avatar coolcat-creations
coolcat-creations - comment - 24 Jan 2017

It doesn´t work then - thank you for explaining the context

avatar coolcat-creations
coolcat-creations - comment - 24 Jan 2017

That´s for testinginstructions:

Include:
`<?php

// Article-Fields Mapping

foreach ($item->fields as $field) {
$item->fieldalias[$field->alias]=$field->id;
}

$itemfield = $item->fieldalias;

// User-Fields Mapping

foreach ($user->fields as $field) {
$user->fieldalias[$field->alias]=$field->id;
}

$userfield = $user->fieldalias;

?>

fields[$itemfield['superfield']]->value; ?>

fields[$userfield['authorinfo']]->value; ?>

`

in your Newsflash module override (replace superfield and authorinfo with the alias of the fields you created and filled (one for the user one for the article).
See if the field contents are displayed.

avatar laoneo laoneo - change - 24 Jan 2017
Labels Added: ?
avatar coolcat-creations
coolcat-creations - comment - 24 Jan 2017

I have tested this item successfully on c1e64da

Tested successful with the article fields, if it gets merged i´d add the user fields for displaying authorinformation in another PR. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13708.

avatar laoneo laoneo - edited - 24 Jan 2017
avatar coolcat-creations coolcat-creations - test_item - 24 Jan 2017 - Tested successfully
avatar laoneo
laoneo - comment - 26 Jan 2017

I'v updated the test instructions, can the label being removed please, or merge by review as it is a small change only.

avatar laoneo laoneo - change - 30 Jan 2017
The description was changed
Labels Removed: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Jan 2017

I have tested this item successfully on 9d6a379

After Override of "mod_articles_news" fields are shown in Module. Can't find $item->fields in Override-Folder in default.php, horizontal.php, vertical.php.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13708.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 30 Jan 2017 - Tested successfully
avatar laoneo
laoneo - comment - 30 Jan 2017

Thanks to the testers. Can be set to RTC.

avatar Bakual Bakual - change - 30 Jan 2017
Status Pending Ready to Commit
avatar laoneo
laoneo - comment - 1 Feb 2017

Somehow the tests disappeared on the issue tracker item.

avatar mbabker
mbabker - comment - 1 Feb 2017

The tests are logged against the last commit from the PR. So when you push a new commit, it "resets" the state. The logic is people are testing a pull request at a given state so if you make changes those tests don't include those changes.

avatar laoneo
laoneo - comment - 1 Feb 2017

I just did some code styling in my last commit and the label RTC is set. So I guess all is good. Thanks for the answer.

avatar wilsonge wilsonge - change - 1 Feb 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-01 17:53:44
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 1 Feb 2017
avatar wilsonge wilsonge - merge - 1 Feb 2017
avatar wilsonge
wilsonge - comment - 1 Feb 2017

Thanks!

Add a Comment

Login with GitHub to post a comment