User tests: Successful: Unsuccessful:
Pull Request for Issue #13705.
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Front End |
Labels |
Added:
?
|
Just a stupid question, do we still need the $item->introtext = JHtml::_('content.prepare', $item->introtext, '', 'mod_articles_news.content');
then? Because that one afaik triggers the same event but only with the introtext instead of the full item.
Guess not.
tested with and without$item->introtext = JHtml::_('content.prepare', $item->introtext, '', 'mod_articles_news.content');
and it works.
You would have to test if content plugins tags within that introtext are still correctly replaced. That's what the content.prepare event usually does take care of.
It doesn´t work then - thank you for explaining the context
That´s for testinginstructions:
Include:
`<?php
// Article-Fields Mapping
foreach ($item->fields as $field) {
$item->fieldalias[$field->alias]=$field->id;
}
$itemfield = $item->fieldalias;
// User-Fields Mapping
foreach ($user->fields as $field) {
$user->fieldalias[$field->alias]=$field->id;
}
$userfield = $user->fieldalias;
?>
fields[$itemfield['superfield']]->value; ?>
fields[$userfield['authorinfo']]->value; ?>
`in your Newsflash module override (replace superfield and authorinfo with the alias of the fields you created and filled (one for the user one for the article).
See if the field contents are displayed.
Labels |
Added:
?
|
I have tested this item
Tested successful with the article fields, if it gets merged i´d add the user fields for displaying authorinformation in another PR. Thanks
I'v updated the test instructions, can the label being removed please, or merge by review as it is a small change only.
Labels |
Removed:
?
|
I have tested this item
After Override of "mod_articles_news" fields are shown in Module. Can't find $item->fields
in Override-Folder in default.php, horizontal.php, vertical.php.
Thanks to the testers. Can be set to RTC.
Status | Pending | ⇒ | Ready to Commit |
Somehow the tests disappeared on the issue tracker item.
The tests are logged against the last commit from the PR. So when you push a new commit, it "resets" the state. The logic is people are testing a pull request at a given state so if you make changes those tests don't include those changes.
I just did some code styling in my last commit and the label RTC is set. So I guess all is good. Thanks for the answer.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-01 17:53:44 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
Can you please add a quick test example?