?
avatar laoneo
laoneo
22 Jan 2017

Steps to reproduce the issue

  • On the back end open the menu manager.
  • Select administrator
  • Unpublish "Joomla! Update" in the list directly
    image

Expected result

Joomla Update link in the back end menu under Components should not being visible anymore.

Actual result

Link is visible
image

System information (as much as possible)

Latest staging.

Additional comments

avatar laoneo laoneo - open - 22 Jan 2017
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Jan 2017
avatar zero-24
zero-24 - comment - 22 Jan 2017

Did you set up a custom admin menu. And enabled it in the backend mod_menu?

avatar zero-24
zero-24 - comment - 23 Jan 2017

@izharaazmi can you take a look i'm also unable to understand and test this new feature in 3.7.0alpha2

avatar zero-24 zero-24 - change - 23 Jan 2017
Labels Added: ?
avatar zero-24 zero-24 - labeled - 23 Jan 2017
avatar izharaazmi
izharaazmi - comment - 23 Jan 2017

@laoneo @zero-24 Are you looking at the custom menu or the default preset menu? Unpublishing those menu items does not affect that in the preset menu. Please confirm.

avatar zero-24
zero-24 - comment - 23 Jan 2017

For the custom menu i have not found any way to change that menu or create a new one.

avatar izharaazmi
izharaazmi - comment - 23 Jan 2017

You need to selected "System Links > Heading" in menu type and in the
second tab set that menu item's "Components Container" flag to yes. This
will cause the menu item to behave as the container for those menu items.

Complete details can be found in the actual PR.

avatar zero-24
zero-24 - comment - 23 Jan 2017

Ah. I was confused as the admin menu i have tryed to create just showed me the normal frontend links, yesterday. Today it looks like it work. But i guess @laoneo is come over the same issue than me.

avatar zero-24 zero-24 - change - 23 Jan 2017
Labels Removed: ?
avatar zero-24 zero-24 - unlabeled - 23 Jan 2017
avatar infograf768
infograf768 - comment - 24 Jan 2017

@izharaazmi
We need to find a way to clarify the use of this new feature. Maybe with a Notice when filtering by administrator client.

avatar izharaazmi
izharaazmi - comment - 24 Jan 2017

@infograf768 What notice text do you suggest?

I think we should put everything in the user and developer docs. A link
with the HELP button should then be good. I am not sure where should I go
for this.

[image: View Izhar Aazmi's profile on LinkedIn]
http://in.linkedin.com/in/izharaazmi Izharul Haque Aazmi (Izhar Aazmi)
Bhartiy Digital Laboratories *and *Bhartiy Web Technologies,
11 - Kaveri Enclave - II, Near Swarn Jayanti Nagar, Ramghat Road, Aligarh -
202 001 (UP), India
Visit: www.izharaazmi.com http://www.izharaazmi.com :: Mail:
izharaazmi@gmail.com
izharaazmi@gmail.com

On Tue, Jan 24, 2017 at 4:37 PM, infograf768 notifications@github.com
wrote:

@izharaazmi https://github.com/izharaazmi
We need to find a way to clarify the use of this new feature. Maybe with a
Notice when filtering by administrator client.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13689 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGZUDfFZUmiRsqjI8jStJEDkwLr7EIa4ks5rVduCgaJpZM4LqdHQ
.

avatar laoneo
laoneo - comment - 24 Jan 2017

First question, why can't I unpublish default menu items?

If you want to leave that behavior, then I suggest to disable the publish options in the menu items which can't be changed. Because the first thing I want to do when I set up a new site is to disable some default menu items, because I never use them. That would be so great to have that, to make Joomla slim in the back end, tailored to the needs of the site admin.

avatar izharaazmi
izharaazmi - comment - 24 Jan 2017

First question, why can't I unpublish default menu items?

You CAN. If you are using your custom admin menu.
We just don't change the way the old preset behaves.

avatar infograf768
infograf768 - comment - 24 Jan 2017

Not sure, but what I am sure of is that something has to be done to prevent trashing/deleting Main (Protected) menu items.
In my opinion, we should not be able to change the status of protected menus.
In fact I think this is a release blocker.

I just made a new install where I could delete the Tags menu...
screen shot 2017-01-24 at 14 43 33

screen shot 2017-01-24 at 14 45 13

avatar izharaazmi
izharaazmi - comment - 24 Jan 2017

Not being able to trash/delete - I do agree.

Not being able to unpublish - I don't think so. How else we would hide them
in our components menu container after we have created the relevant link at
our place of choice?

avatar infograf768
infograf768 - comment - 24 Jan 2017

Maybe a little more complex, but imho we should first check if a custom admin menu exists before being to publish/unpublish a protected menu item.
For trash delete, it is real important to correct now, maybe by showing the toolbar button ONLY when the list is filtered by site

avatar izharaazmi
izharaazmi - comment - 24 Jan 2017

@infograf768 What is your opinion about batch operations on those protected
menu items?

avatar infograf768
infograf768 - comment - 24 Jan 2017

@izharaazmi
Batch is also a useless one imho

avatar infograf768
infograf768 - comment - 24 Jan 2017

I tested this OK

// Add a batch button
		if ($user->authorise('core.create', 'com_menus')
			&& $user->authorise('core.edit', 'com_menus')
			&& $user->authorise('core.edit.state', 'com_menus')
			&& $this->state->get('filter.client_id') == 0)
		{
			$title = JText::_('JTOOLBAR_BATCH');

			// Instantiate a new JLayoutFile instance and render the batch button
			$layout = new JLayoutFile('joomla.toolbar.batch');

			$dhtml = $layout->render(array('title' => $title));
			$bar->appendButton('Custom', $dhtml, 'batch');
		}

		if ($this->state->get('filter.published') == -2 
			&& $canDo->get('core.delete')
			&& $this->state->get('filter.client_id') == 0)
		{
			JToolbarHelper::deleteList('JGLOBAL_CONFIRM_DELETE', 'items.delete', 'JTOOLBAR_EMPTY_TRASH');
		}
		elseif ($canDo->get('core.edit.state') && $this->state->get('filter.client_id') == 0)
		{
			JToolbarHelper::trash('items.trash');
		}
avatar izharaazmi
izharaazmi - comment - 24 Jan 2017

@infograf768 What I see in your code that you are hiding batch/delete/trash for ALL backend menu items. Is that what you intend?

IMHO this is not what we want for our custom menu items!

avatar infograf768
infograf768 - comment - 24 Jan 2017

What I see in your code that you are hiding batch/delete/trash for ALL backend menu items. Is that what you intend?

That is what I think makes the more sense and less prone to errors.

avatar infograf768
infograf768 - comment - 24 Jan 2017

Testing now your PR
#13739

avatar izharaazmi
izharaazmi - comment - 24 Jan 2017

Are you going to provide a patch?

I have already a minute ago ?

That is what I think makes the more sense and less prone to errors.

How will we then move, copy, unpublish or delete a custom adminmenu menu item?

avatar infograf768
infograf768 - comment - 24 Jan 2017

You are right

avatar laoneo
laoneo - comment - 24 Jan 2017

I'v applied the patch. But I'm still able to unpublish menu items from the protected ones, which will appear in the back end menu as described in the issue description.

avatar infograf768
infograf768 - comment - 24 Jan 2017

Unpublishing these will ONLY work for a custom admin menu which contains a menu item of type Page Heading where the parameter "Component Menu Container" is set to yes.

Will comment in that PR for the rest

avatar izharaazmi
izharaazmi - comment - 24 Jan 2017

I'v applied the patch. But I'm still able to unpublish...

In the other PR? Unpublish is available on purpose. This is to let users hide those menu items from their custom menu items and still have a components menu container for any component they install later.

Use case is that they will hide all those and have a custom menu item where they desire. Therefore making the components container have nothing to show. This will cause that container to hide itself until a new component in installed with a new protected menu item for it.

avatar laoneo
laoneo - comment - 24 Jan 2017

From my simple minded understanding, when I can unpublish a menu item in the protected menu then it should not being show when the protected menu is active. If this behavior should not being supported in the protected menu item, then it should be disabled. I have now a test environment with a unpublished menu item which is shown.

avatar izharaazmi
izharaazmi - comment - 24 Jan 2017

@infograf768 What do you suggest about the behaviour of unpublished protected menu items for preset menu? @laoneo has a valid point. And what I did was under B/C consideration.

PS: Earlier (before this feature) those menu items were essentially unpublished and still always shown.

avatar infograf768
infograf768 - comment - 25 Jan 2017

Folks
@izharaazmi @laoneo
Here are my thoughts:
#13739 (comment)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Feb 2017

@laoneo isn't this Issue fixed by #13830?

avatar laoneo
laoneo - comment - 11 Feb 2017

I guess we can close this one or @izharaazmi and @infograf768 ?

avatar zero-24 zero-24 - change - 11 Feb 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-02-11 08:19:28
Closed_By zero-24
avatar zero-24 zero-24 - close - 11 Feb 2017

Add a Comment

Login with GitHub to post a comment