J3 Issue ?
avatar flyingwombats
flyingwombats
21 Jan 2017

Steps to reproduce the issue

Look at onExtensionBeforeUpdate. It doesn't contain the extension ID that is about to be updated!!

Expected result

I have the extension ID to manipulate anything I need to

Actual result

I don't have the extension ID and I feel sadness

System information (as much as possible)

Joomla 3.7

Additional comments

N/A. Report by @wilsonge

avatar flyingwombats flyingwombats - open - 21 Jan 2017
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Jan 2017
avatar wilsonge
wilsonge - comment - 21 Jan 2017

Confirmed at London super sprint

On Sat, 21 Jan 2017 at 21:25, Phil Walton notifications@github.com wrote:

Steps to reproduce the issue

Look at onExtensionBeforeUpdate. It doesn't contain the extension ID that
is about to be updated!!
Expected result

I have the extension ID to manipulate anything I need to
Actual result

I don't have the extension ID and I feel sadness
System information (as much as possible)

Joomla 3.7
Additional comments

N/A. Report by @wilsonge https://github.com/wilsonge


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13674, or mute the thread
https://github.com/notifications/unsubscribe-auth/AB5N0M58pzstPVwIWXwgXkhqfGgxbnQaks5rUne8gaJpZM4LqMBp
.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Feb 2017

This is the line that needs to be changed :)

by?

avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Mar 2017
Category com_plugins
avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Apr 2017
Status New Confirmed
avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Nov 2017
Status Confirmed Discussion
avatar brianteeman brianteeman - change - 25 Mar 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar wilsonge wilsonge - change - 20 Jul 2018
Labels Added: ?
avatar wilsonge wilsonge - labeled - 20 Jul 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 31 May 2019
Labels Removed: ?
avatar franz-wohlkoenig franz-wohlkoenig - unlabeled - 31 May 2019
avatar ReLater
ReLater - comment - 1 Jun 2019

As far as I see the extension id is unknown yet when onExtensionBeforeUpdate is triggered. Thus it must be calculated in the plugin itself based upon the manifest data with a db query OR the logic of the core Installer/Update process must be changed significantly.

I just flew over the code and don't see a practicable/acceptable way.
Objection welcome ;-)

With other words: I would close tis issue but I'm not sure.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Jun 2019

closed as stated above as it can always reopened if needed. thanks @ReLater

avatar franz-wohlkoenig franz-wohlkoenig - close - 1 Jun 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Jun 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-06-01 09:46:59
Closed_By franz-wohlkoenig

Add a Comment

Login with GitHub to post a comment