[#13656] - Fix save user without selecting user groups
- Fixed in Code Base
- 21 Feb 2017
- Medium
- Build: staging
- # 13656
- Diff
- joomdonation:patch-12
User tests: Successful: Unsuccessful:
Pull Request for Issue #13653.
Summary of Changes
This PR prevents add/edit an account without selecting a user groups in the backend of your site. It also fixes a notice Undefined index: groups... when administrator update his own account from backend
Testing Instructions
Test case 1: Login to administrator are of your site using super admin account, try to add/edit an user
- Before patch, you can add/edit an account without selecting a user group
- After patch, if you try to add/edit an account without selecting at least one user groups, error will be thrown and account won't be saved
Test case 2: Login to administrator area of your site using an administrator account, edit your account, make sure it is saved properly
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users Language & Strings |
| Title |
|
||||||
| Labels |
Added:
?
?
|
||
I have tested this item
Tested on Joomla 3.7.0-beta1 and works perfect!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13656.
Thanks @renekreijveld and @genesisfan for testing the PR.
I just updated code to remove an unnecessary nested if, no need for testing it again.
This PR had two successful tests. Could someone please add RTC label ?
@joomdonation can I be picky and can you please add a full stop to the end of your new language string as per the others above.
Yes, done. Thanks @tonypartridge
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-21 00:26:46 |
| Closed_By | ⇒ | joomdonation |
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-02-21 00:26:46 | ⇒ | |
| Closed_By | joomdonation | ⇒ |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-21 10:17:01 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on e68775f
Tested on Joomla 3.7.0-beta1, works perfect!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13656.