[#13643] - Properly merge tag params
- Fixed in Code Base
- 21 Jan 2017
- Medium
- Build: staging
- # 13643
- Diff
- Bakual:FixTagParamsMerging
User tests: Successful: Unsuccessful:
Pull Request for Issue #13641.
Summary of Changes
I don't know what to say after looking at that code... That stuff certainly didn't work at all before.
In short, item and menu params are now properly merged.
Testing Instructions
Test that tag parameters are merged properly, meaning that options set in the tag override those in the menu item. Except when the menu item is an exact match to the tag (eg it's a single tag menuitem for that specific tag shown), then the menu item takes precedence over the tag params
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
Test-Scenario:
- 2 Tags without single tag menuitem
- menuitem
list-of-all-tags, no other tag-menuitemtype published - 2 tags are shown
- click on one tag got
Call to a member function get() on string. Same if click on tag in an article. - if menuitem
list-of-all-tagsis unpublished, got correct view "index.php/component/tags/tag/*"
| Labels |
Added:
?
|
||
The error was a typo on my part. Can you try again?
I also fixed another bug I saw that the single tag view loaded the layout parameter from the tags list view... sigh
menuitem list-of-all-tags works. Furthermore testing.
- In "Tags > Options" a "Tag Image" is set on "Show" and is displayed.
- In an Tag on Tab "Images" set Float of "Full Image" to "Right". This don't work, Image stay left.
The parameter for the image float seems to be not used at all in com_tags. That would be a different PR to add this, but not one I'm going to write
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13643.
Thanks for getting to this one so quickly! I will test it out now.
I have tested this item
Patch applied to the view.html.php file all is working good from the issue I reported. Tags View Layout (one without a menu item) is now grabbing the correct layout selected in the single Tag parameters and not choosing the one set in Global Tags Component Options.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13643.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13643.
@justinherrin does
Tags View Layout (one without a menu item) is now grabbing the correct layout selected in the single Tag parameters and not choosing the one set in Global Tags Component Options.
mean i can close #13646?
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-21 19:09:23 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
will test today.