[#13639] - removed code as advised in #13631
- Closed
- 17 Jul 2017
- Medium
- Build: staging
- # 13639
- Diff
- rdeutz:remove_incompatible_fof_parts_adminmenu
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #13631 .
Summary of Changes
Removed code as advised in #13631
Testing Instructions
- Install latest staging
- Install an extension that used the with Joomla! core shipped fof version
- Create a 2nd admin menu with a menu item pointing to the above installed extension
- Install an update of the extension
-> menu items are deleted
Apply patch
- Install latest staging
- Install an extension that used the with Joomla! core shipped fof version
- Create a 2nd admin menu with a menu item pointing to the above installed extension
- Install an update of the extension
-> menu items are NOT deleted
Documentation Changes Required
Mention in release notes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Libraries |
I know someone has to review this
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-26 11:26:31 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-03-26 11:26:31 | ⇒ | |
| Closed_By | rdeutz | ⇒ |
| Status | New | ⇒ | Pending |
Someone should change the milestone, now as 3.7.0 is released ;-)
| Milestone |
Removed: |
||
I hate to say it, but following what has been policy; this should be closed like every other PR that makes changes to 3rd party libraries. (who cares that FOF2 is EOL and that the author has specifically said that we can make the necessary updates. Hasn't stopped the closing all of the other PR's to fix the bundled FOF2 issues)
I closing this, I can't make the problem occur so I don't see how to prove the fix is a fix and not only a change :-)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-17 12:11:52 |
| Closed_By | ⇒ | rdeutz |
seems #13642 is the bigger problem