Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13635] - Clean up JControllerAdmin

? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
18 Jan 2017

Pull Request for Issue # .

Summary of Changes

This PR clean up JControllerAdmin class:

  1. Replace deprecated JArrayHelper class with Joomla\Utilities\ArrayHelper

  2. Remove one time usage $app variable, call JFactory::getApplication() directly

Testing Instructions

Code review

Documentation Changes Required

None

avatar joomdonation joomdonation - open - 18 Jan 2017
avatar joomdonation joomdonation - change - 18 Jan 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jan 2017
Category ⇒ Libraries
avatar joomdonation joomdonation - change - 19 Jan 2017
The description was changed
avatar joomdonation joomdonation - edited - 19 Jan 2017
avatar csthomas
csthomas - comment - 19 Jan 2017

I have tested this item ✅ successfully on 6ffd82f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13635.

avatar csthomas csthomas - test_item - 19 Jan 2017 - Tested successfully
avatar wilsonge
wilsonge - comment - 20 Jan 2017

Merging on review with the one good test

avatar wilsonge wilsonge - change - 20 Jan 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-01-20 10:25:51
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 20 Jan 2017
avatar wilsonge wilsonge - merge - 20 Jan 2017
avatar joomdonation
joomdonation - comment - 20 Jan 2017

Thanks @csthomas and @wilsonge

Add a Comment

Login with GitHub to post a comment