[#13619] - Update for menu, sync menutype and client_id
- Fixed in Code Base
- 18 Jan 2017
- Medium
- Build: staging
- # 13619
- Diff
- rdeutz:admin_menu_update_menutype_sync
User tests: Successful: Unsuccessful:
Summary of Changes
We use different menutype values for the admin menu. This PR syncs the used name for updating old installations. It also sets the client_id for admin menus to 1
Testing Instructions
- Install Joomla
- Install an extension
Make sure everything works.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql MS SQL |
| Labels |
Added:
?
|
||
I don't see a reason to have menutype == menu, the menutype isn't used at all before 3.7. I think I have found in old sites that has client_id = 0 for admin menu item but while thinking about it again I might be wrong. Whatever it doesn't hurt :-)
Bakual
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-18 14:25:08 |
| Closed_By | ⇒ | Bakual |
So now should we get rid of the dropdown option "Menu (protected)" in the menu manager filter or keep it for just in case B/C?
@brianteeman I work on PR, give me about an hour.
@brianteeman issue created #15671
Yes, that change is pathetic and should never have been made :-(
@rdeutz Do you intend to make
"menutype" = 'menu'obsolete/deprecate?I also find the client_id to be already "1" as of J3.6.5. Why do we need to do that update sql?