[#13610] - Add "id" attribute to calendar element
- Fixed in Code Base
- 27 Jan 2017
- Medium
- Build: staging
- # 13610
- Diff
- Bakual:AddIdToCalendar
User tests: Successful: Unsuccessful:
Calendar formfield currently don't have an ID attribute set.
Summary of Changes
Adds the ID attribute to the calendar formfield
Testing Instructions
Check any calendar formfield (eg article "Start Publishing"). In the HTML sourcecode you should see the ID attribute on the input element.
Also, clicking on the label should now activate the calendar popup.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
Each formfield in JForm has an ID, calendar shouldn't be an exception here. It breaks the label assignment (for="jform_calendarfield_id) and obviously breaks any JavaScript that interacts with it. The latter is why I discovered it in my extension.
Repeatable forms need a different way to deal with such things. Removing the ID from formfields isn't an option.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13610.
I have tested this item
### Without PR
<div class="input-append"> <input type="text" name="jform[publish_up]" value="2017-01-22 19:41:00"size="22"
With PR
<div class="input-append"> <input type="text" id="jform_publish_up" name="jform[publish_up]" value="2017-01-22 19:41:00"size="22"
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13610.
| Title |
|
||||||
| Status | Pending | ⇒ | Ready to Commit | ||||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13610.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-27 18:23:58 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
@Bakual that was removed in order to make the calendar compatible with repeatable forms, so I have no clue if that will strike back somehow. but why do you need an id for?