? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
15 Jan 2017

Pull Request for Issue #13567 .

This is a straight redo of #13567 with the changes proposed by @mbabker

Summary of Changes

Extension updates that pull the install file from Github fail because no user_agent is supplied. This proposed change provides a userAgent to the http transport adapter. Put userAgent value in options passed to http transport adapter.

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 15 Jan 2017
avatar wilsonge wilsonge - change - 15 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jan 2017
Category Libraries
avatar csthomas
csthomas - comment - 24 Jan 2017

I have tested this item successfully on 1d020d6

Code review.

I did not found any example of not working link before patch.
I tested before and after patch on update plugin from the web - no difference.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13605.

avatar csthomas csthomas - test_item - 24 Jan 2017 - Tested successfully
avatar marrouchi
marrouchi - comment - 24 Jan 2017

@wilsonge Can you please add some test instructions ? I have no idea how to reproduce the issue.

avatar zero-24 zero-24 - change - 4 Feb 2017
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Feb 2017

same like @marrouchi at @wilsonge.

avatar brianteeman
brianteeman - comment - 21 Jul 2018

@wilsonge it has been over a year since you created this PR. It now has conflicts that require resolving. If this is something we need then it should be fixed. If not then please close it

avatar wilsonge wilsonge - change - 21 Jul 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-07-21 23:21:03
Closed_By wilsonge
avatar wilsonge wilsonge - close - 21 Jul 2018
avatar wilsonge
wilsonge - comment - 21 Jul 2018

This was just a redo of someone else's work. Given no one knows how to reproduce I'm closing it

Add a Comment

Login with GitHub to post a comment