? Pending

User tests: Successful: Unsuccessful:

avatar joomlabeat
joomlabeat
14 Jan 2017

Pull Request for Issue #13588.

Summary of Changes

Moved the inclusion of ContentHelperRoute Class from the helper.php to the mod_articles_categories.php

Testing Instructions

Create a module to list categories of a parent category. The module should work.

Documentation Changes Required

No changes are required.

avatar joomlabeat joomlabeat - open - 14 Jan 2017
avatar joomlabeat joomlabeat - change - 14 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jan 2017
Category Modules Front End
avatar bertmert
bertmert - comment - 14 Jan 2017

@joomlabeat
I could reproduce the issue in current Staging (3.7.0) only

  • with enabled cache (configuration) and after second loading of page,
  • only on a page like Featured Contacts or Login.

Could you please check and complete the testing instructions if you can confirm that. Thank you.

avatar joomdonation
joomdonation - comment - 15 Jan 2017

I have tested this item successfully on 8245124

I was able to re-procedure this error and this PR fixed it.

From code review, when cache data is found, the file modules/mod_articles_categories/helper.php won't be required, so ContentHelperRoute is not registered and not available for using in module layout file, thus fatal error happens

For tester, you want to test it;

  1. Make sure cache is enabled for your site and the module

  2. Assign the module to a menu item not related to com_content. Then access to that menu item, from the second time you should see the error. Apply the patch, the error should be gone..


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13590.
avatar joomdonation joomdonation - test_item - 15 Jan 2017 - Tested successfully
avatar sanderpotjer
sanderpotjer - comment - 15 Jan 2017

I have tested this item successfully on 8245124

@joomlabeat thanks! Explains an issue a came across recently, this is fixing that indeed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13590.

avatar sanderpotjer sanderpotjer - test_item - 15 Jan 2017 - Tested successfully
avatar infograf768 infograf768 - change - 15 Jan 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 15 Jan 2017

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13590.

avatar wilsonge wilsonge - change - 15 Jan 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-15 17:56:13
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 15 Jan 2017
avatar wilsonge wilsonge - merge - 15 Jan 2017
avatar Warolf
Warolf - comment - 22 Feb 2017

I had the same problem but in the 3.6.5 version, i add the fix you have here and all good just passed 8 hours and all good


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13590.

Add a Comment

Login with GitHub to post a comment