[#13571] - Fixing search for MySQL
- Fixed in Code Base
- 12 Jan 2017
- Medium
- Build: staging
- # 13571
- Diff
- Bakual:FixSearchMySQL
User tests: Successful: Unsuccessful:
Pull Request for Issue #13569 .
Apparently, MySQL can't cast to INTEGER while PostgreSQL and MariaDB can.
Summary of Changes
This PR changes the casting the other way around and makes use of the existing castAsChar() method we have in the querybuilder.
Testing Instructions
Test regular search (not smart search) on various database engines (MySQL, PostgreSQL)
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item
With patch applied the error is gone and search works. confirmed
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13571.
Tested on MySQL and error from before now gone :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13571.
OK here too on mysql
| Labels |
Added:
?
|
||
I have tested this item
Test OK - MySQL.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13571.
I have tested this item
TEsted succefully, on both mysql and postgresql.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13571.
I have tested this item
Tested on sql server in combination with PR #13262
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13571.
IMHO It would be good to change type of item_id to integer on another PR.
I have tested this item
on postgresql works as before
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13571.
can we have RTC here as has been tested on 3 db's
on last thing for me is #13571 (comment)
pinging @laoneo
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13571.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-12 18:08:01 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
IMHO It would be good to change type of
item_idto integer on another PR.
Sorry for necroposting, but does anyone know why item_id on the fields_values table is not an INT but a VARCHAR?
@alikon Can you test that on PostgreSQL and review the change?